[PR #363] [MERGED] Support DNS-SD over mDNS #1386

New issue

Closed

opened 2026-03-16 02:03:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:03:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/363
Author: @bluejekyll
Created: 3/26/2018
Status: ✅ Merged
Merged: 4/8/2018
Merged by: @bluejekyll

Base: master ← Head: support-mdns-sd

📝 Commits (10+)

867d4b2 refactor DnsFuture for multiple responses
36d1016 clean up some tests
2a6806b thread DnsRequest through all DnsHandles
f816994 fix all-features
73fc7b4 clean up warnings
57d2488 thread DnsRequestOptions through Resolver
28791c2 change all DnsHandles to return DnsResponse
38f54d3 refactor to allow multiple messages per DnsResponse
b944989 refactor SRV lookups to standard functions
4333d96 SRV lookups now have associated IPs, needs restriction

📊 Changes

44 files changed (+1915 additions, -1013 deletions)

View changed files

📝 Cargo.lock (+57 -39)
📝 client/README.md (+6 -6)
📝 client/src/client/client.rs (+15 -19)
📝 client/src/client/client_future.rs (+19 -15)
📝 client/src/client/memoize_client_handle.rs (+19 -12)
📝 client/src/lib.rs (+5 -5)
📝 client/src/op/mod.rs (+1 -0)
📝 integration-tests/src/mock_client.rs (+10 -7)
📝 integration-tests/tests/client_tests.rs (+97 -88)
📝 integration-tests/tests/lookup_tests.rs (+27 -33)
📝 integration-tests/tests/name_server_pool_tests.rs (+59 -40)
📝 integration-tests/tests/secure_client_handle_tests.rs (+57 -59)
📝 proto/Cargo.toml (+1 -0)
📝 proto/src/lib.rs (+8 -87)
📝 proto/src/multicast/mdns_client_stream.rs (+13 -11)
📝 proto/src/multicast/mdns_stream.rs (+8 -12)
📝 proto/src/rr/domain/label.rs (+7 -0)
📝 proto/src/rr/domain/mod.rs (+3 -3)
➕ proto/src/rr/domain/try_parse_ip.rs (+66 -0)
📝 proto/src/rr/rdata/txt.rs (+18 -3)

...and 24 more files

📄 Description

With mDNS support having landed, we can now start working on DNS service discovery. This PR is the work to get there.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/363 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 3/26/2018 **Status:** ✅ Merged **Merged:** 4/8/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `support-mdns-sd` --- ### 📝 Commits (10+) - [`867d4b2`](https://github.com/hickory-dns/hickory-dns/commit/867d4b25582639366c371f725f3163136282afc7) refactor DnsFuture for multiple responses - [`36d1016`](https://github.com/hickory-dns/hickory-dns/commit/36d101677b9e54413761e1138f4396e474c1bacb) clean up some tests - [`2a6806b`](https://github.com/hickory-dns/hickory-dns/commit/2a6806bb1017466398a7e11bacf1c440a9233f9b) thread DnsRequest through all DnsHandles - [`f816994`](https://github.com/hickory-dns/hickory-dns/commit/f8169943b23f2df4f04fdf0d0b0f25575e731e5a) fix all-features - [`73fc7b4`](https://github.com/hickory-dns/hickory-dns/commit/73fc7b472408368c34e86951f11ff797e2fcf9fd) clean up warnings - [`57d2488`](https://github.com/hickory-dns/hickory-dns/commit/57d2488c10c22c65513e2edfb95d6603f547dcb3) thread DnsRequestOptions through Resolver - [`28791c2`](https://github.com/hickory-dns/hickory-dns/commit/28791c2955d0c55ed0528adcdb939a33b08da8ea) change all DnsHandles to return DnsResponse - [`38f54d3`](https://github.com/hickory-dns/hickory-dns/commit/38f54d39bde781bd3ff7027d75ce8a207e6e038e) refactor to allow multiple messages per DnsResponse - [`b944989`](https://github.com/hickory-dns/hickory-dns/commit/b944989aaaaf838df040e2022323d7ccd3c13410) refactor SRV lookups to standard functions - [`4333d96`](https://github.com/hickory-dns/hickory-dns/commit/4333d96f5e8c8c459c557d4ddfc4ff836b626700) SRV lookups now have associated IPs, needs restriction ### 📊 Changes **44 files changed** (+1915 additions, -1013 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+57 -39) 📝 `client/README.md` (+6 -6) 📝 `client/src/client/client.rs` (+15 -19) 📝 `client/src/client/client_future.rs` (+19 -15) 📝 `client/src/client/memoize_client_handle.rs` (+19 -12) 📝 `client/src/lib.rs` (+5 -5) 📝 `client/src/op/mod.rs` (+1 -0) 📝 `integration-tests/src/mock_client.rs` (+10 -7) 📝 `integration-tests/tests/client_tests.rs` (+97 -88) 📝 `integration-tests/tests/lookup_tests.rs` (+27 -33) 📝 `integration-tests/tests/name_server_pool_tests.rs` (+59 -40) 📝 `integration-tests/tests/secure_client_handle_tests.rs` (+57 -59) 📝 `proto/Cargo.toml` (+1 -0) 📝 `proto/src/lib.rs` (+8 -87) 📝 `proto/src/multicast/mdns_client_stream.rs` (+13 -11) 📝 `proto/src/multicast/mdns_stream.rs` (+8 -12) 📝 `proto/src/rr/domain/label.rs` (+7 -0) 📝 `proto/src/rr/domain/mod.rs` (+3 -3) ➕ `proto/src/rr/domain/try_parse_ip.rs` (+66 -0) 📝 `proto/src/rr/rdata/txt.rs` (+18 -3) _...and 24 more files_ </details> ### 📄 Description With mDNS support having landed, we can now start working on DNS service discovery. This PR is the work to get there. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>