[PR #722] [MERGED] Improve Additional processing #1635

New issue

Closed

opened 2026-03-16 02:17:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:17:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/722
Author: @bluejekyll
Created: 4/3/2019
Status: ✅ Merged
Merged: 4/5/2019
Merged by: @bluejekyll

Base: master ← Head: support-additional-processing

📝 Commits (2)

d0302b4 improve additional processing
a32185f add additional processing for SRV records

📊 Changes

4 files changed (+311 additions, -100 deletions)

View changed files

📝 crates/server/src/store/in_memory/authority.rs (+104 -68)
📝 crates/server/tests/authority_battery/basic.rs (+161 -20)
📝 crates/server/tests/authority_battery/dnssec.rs (+42 -11)
📝 crates/server/tests/named_test_configs/example.com.zone (+4 -1)

📄 Description

fyi @Darkspirit

Fixes: #513

This is ready for merge, it will process additionals for these types: ANAME, NS, MX, CNAME, and SRV. Lookups for ANAME, NS, MX, and SRV types, will process additionals to attempt to find A or AAAA records. If a lookup is for the CNAME explicitly (as opposed to any other type that's name matches the CNAME), only additional CNAME chains will be returned, but no additional processing after that.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/722 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 4/3/2019 **Status:** ✅ Merged **Merged:** 4/5/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `support-additional-processing` --- ### 📝 Commits (2) - [`d0302b4`](https://github.com/hickory-dns/hickory-dns/commit/d0302b4093def15c6c697c1421491697ed92ae43) improve additional processing - [`a32185f`](https://github.com/hickory-dns/hickory-dns/commit/a32185f61e3c82b77aec34fd8f718fa2fe9c6b8e) add additional processing for SRV records ### 📊 Changes **4 files changed** (+311 additions, -100 deletions) <details> <summary>View changed files</summary> 📝 `crates/server/src/store/in_memory/authority.rs` (+104 -68) 📝 `crates/server/tests/authority_battery/basic.rs` (+161 -20) 📝 `crates/server/tests/authority_battery/dnssec.rs` (+42 -11) 📝 `crates/server/tests/named_test_configs/example.com.zone` (+4 -1) </details> ### 📄 Description fyi @Darkspirit Fixes: #513 This is ready for merge, it will process additionals for these types: ANAME, NS, MX, CNAME, and SRV. Lookups for ANAME, NS, MX, and SRV types, will process additionals to attempt to find A or AAAA records. If a lookup is for the CNAME explicitly (as opposed to any other type that's name matches the CNAME), only additional CNAME chains will be returned, but no additional processing after that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>