mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[GH-ISSUE #1647] missing field tls_config in initializer of NameServerConfig #722
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#722
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @williamdes on GitHub (Feb 27, 2022).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1647
Describe the bug
While building our docker image I was thinking that I could enable all features but it seems like not.
Here is the error I have (reproduced here: https://github.com/trust-dns/docker/runs/5352792304?check_suite_focus=true#step:3:896)
After removing the feature from the list the build step passes: https://github.com/trust-dns/docker/runs/5352804946?check_suite_focus=true#step:3:891
To Reproduce
Clone https://github.com/trust-dns/docker
Edit
alpine/Dockerfileto add the featuredns-over-https-rustlson line 8Expected behavior
Build
System:
Version:
Version: 0.21.0
Additional context
Feature:
dns-over-https-rustls@bluejekyll commented on GitHub (Feb 28, 2022):
I was able to reproduce your error, I'm trying to figure out why this is happening, it seems like it should work as is, but clearly is not. I'll come up with a fix and publish a 0.21.1 release.
@bluejekyll commented on GitHub (Feb 28, 2022):
@williamdes, 0.21.1 has been published, should fix the issue you were seeing.
@williamdes commented on GitHub (Feb 28, 2022):
Hi @bluejekyll
Thank you so much for the quick fix and release !
It works: https://github.com/trust-dns/docker/actions/runs/1909071075
I will make a 0.21.1 release in docker when you have some time to fill details for: https://github.com/trust-dns/docker/issues/1 ;)