[PR #1640] [MERGED] deprecate outdated dnssec algorithms #2479

New issue

Closed

opened 2026-03-16 08:56:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:56:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1640
Author: @bluejekyll
Created: 2/18/2022
Status: ✅ Merged
Merged: 2/20/2022
Merged by: @bluejekyll

Base: main ← Head: deprecate-older-algorithms

📝 Commits (1)

c83f916 deprecate outdated dnssec algorithms

📊 Changes

13 files changed (+41 additions, -3 deletions)

View changed files

📝 bin/tests/named_test_rsa_dnssec.rs (+1 -0)
📝 crates/client/src/rr/dnssec/key_format.rs (+2 -1)
📝 crates/client/src/rr/dnssec/keypair.rs (+2 -0)
📝 crates/client/src/serialize/txt/parse_rdata.rs (+1 -0)
📝 crates/client/src/serialize/txt/rdata_parsers/ds.rs (+2 -0)
📝 crates/proto/src/rr/dnssec/algorithm.rs (+19 -2)
📝 crates/proto/src/rr/dnssec/digest_type.rs (+1 -0)
📝 crates/proto/src/rr/dnssec/public_key.rs (+2 -0)
📝 crates/proto/src/rr/dnssec/supported_algorithm.rs (+6 -0)
📝 crates/proto/src/rr/rr_set.rs (+1 -0)
📝 crates/proto/tests/dnssec_presentation_format_tests.rs (+2 -0)
📝 crates/server/src/config/dnssec.rs (+1 -0)
📝 util/src/get_root_ksks.rs (+1 -0)

📄 Description

after reviewing #1635, I noticed that that we have comments to not use, but felt it ideal that we deprecate specific algorithm types such that a compiler error will occur if used.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1640 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 2/18/2022 **Status:** ✅ Merged **Merged:** 2/20/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `deprecate-older-algorithms` --- ### 📝 Commits (1) - [`c83f916`](https://github.com/hickory-dns/hickory-dns/commit/c83f916a6a4d3734ac5cce167dda7f3a7f920eea) deprecate outdated dnssec algorithms ### 📊 Changes **13 files changed** (+41 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/named_test_rsa_dnssec.rs` (+1 -0) 📝 `crates/client/src/rr/dnssec/key_format.rs` (+2 -1) 📝 `crates/client/src/rr/dnssec/keypair.rs` (+2 -0) 📝 `crates/client/src/serialize/txt/parse_rdata.rs` (+1 -0) 📝 `crates/client/src/serialize/txt/rdata_parsers/ds.rs` (+2 -0) 📝 `crates/proto/src/rr/dnssec/algorithm.rs` (+19 -2) 📝 `crates/proto/src/rr/dnssec/digest_type.rs` (+1 -0) 📝 `crates/proto/src/rr/dnssec/public_key.rs` (+2 -0) 📝 `crates/proto/src/rr/dnssec/supported_algorithm.rs` (+6 -0) 📝 `crates/proto/src/rr/rr_set.rs` (+1 -0) 📝 `crates/proto/tests/dnssec_presentation_format_tests.rs` (+2 -0) 📝 `crates/server/src/config/dnssec.rs` (+1 -0) 📝 `util/src/get_root_ksks.rs` (+1 -0) </details> ### 📄 Description after reviewing #1635, I noticed that that we have comments to not use, but felt it ideal that we deprecate specific algorithm types such that a compiler error will occur if used. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>