[GH-ISSUE #428] mdns socket creation should use Handle::current #482

New issue

Closed

opened 2026-03-15 22:44:51 +03:00 by kerem · 1 comment

kerem commented

2026-03-15 22:44:51 +03:00

Owner

Originally created by @bluejekyll on GitHub (Apr 25, 2018).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/428

@Keruspe , I was reviewing the Handle docs

For mDNS instead of dirtying the interface, should we just use Handle::current and then we won't have the deviation from the other interfaces.

I'm pretty sure that is what's going on with the other Socket creation, just implicitly vs. explicitly.

see https://github.com/carllerche/mio/issues/841#issuecomment-384393244

Originally created by @bluejekyll on GitHub (Apr 25, 2018). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/428 @Keruspe , I was reviewing the Handle docs For mDNS instead of dirtying the interface, should we just use `Handle::current` and then we won't have the deviation from the other interfaces. I'm pretty sure that is what's going on with the other Socket creation, just implicitly vs. explicitly. see https://github.com/carllerche/mio/issues/841#issuecomment-384393244

kerem

2026-03-15 22:44:51 +03:00

closed this issue
added the
crate:proto
label

kerem commented

2026-03-15 22:45:07 +03:00

Author

Owner

@Keruspe commented on GitHub (Apr 26, 2018):

I got to the same conclusion yesterday reading the mio issue and the Handle doc, was planning on testing it today, so here we are

@Keruspe commented on GitHub (Apr 26, 2018): I got to the same conclusion yesterday reading the mio issue and the Handle doc, was planning on testing it today, so here we are

kerem referenced this issue

2026-03-16 02:08:23 +03:00

[PR #482] [MERGED] resolver: Refactor LookupFuture to remove task::current().notify(). #1473