[GH-ISSUE #309] The RequestHandler should return a future #438

New issue

Closed

opened 2026-03-15 22:29:06 +03:00 by kerem · 1 comment

kerem commented

2026-03-15 22:29:06 +03:00

Owner

Originally created by @vorner on GitHub (Dec 2, 2017).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/309

In many cases, the server doesn't know the answer right away ‒ it needs to ask a database, compute it in a CPU pool or ask another server. For such situation, returning a future instead of an answer is more appropriate and it shouldn't be a big issue for the ones that have the answer ready.

As discussed OOB, this is probably simple enough in itself, but brings further considerations ‒ like what to do when the future returns error (probably ServFail) and if there should be some timeout on the future's processing.

This is also mentioned in #308, but that one is more of a question than an actionable point.

Originally created by @vorner on GitHub (Dec 2, 2017). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/309 In many cases, the server doesn't know the answer right away ‒ it needs to ask a database, compute it in a CPU pool or ask another server. For such situation, returning a future instead of an answer is more appropriate and it shouldn't be a big issue for the ones that have the answer ready. As discussed OOB, this is probably simple enough in itself, but brings further considerations ‒ like what to do when the future returns error (probably ServFail) and if there should be some timeout on the future's processing. This is also mentioned in #308, but that one is more of a question than an actionable point.

kerem

2026-03-15 22:29:06 +03:00

closed this issue
added the
enhance

crate:server

cleanup
labels

kerem commented

2026-03-15 22:29:22 +03:00

Author

Owner

@bluejekyll commented on GitHub (Apr 9, 2019):

As part of #674 the downstream request is now a future:

github.com/bluejekyll/trust-dns@fbfbebe07a/crates/server/src/authority/catalog.rs (L76-L80)

@bluejekyll commented on GitHub (Apr 9, 2019): As part of #674 the downstream request is now a future: https://github.com/bluejekyll/trust-dns/blob/fbfbebe07aa88f914770247c4a49d3ae1a543d33/crates/server/src/authority/catalog.rs#L76-L80

kerem referenced this issue

2026-03-16 02:06:29 +03:00

[PR #438] [MERGED] Switch to tokio-executor, drop use of tokio_core::reactor::Handle #1436