[PR #330] [MERGED] fix triple escape in Name #1369

New issue

Closed

opened 2026-03-16 02:02:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:02:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/330
Author: @bluejekyll
Created: 1/22/2018
Status: ✅ Merged
Merged: 1/22/2018
Merged by: @bluejekyll

Base: master ← Head: fix_name_triple_escape

📝 Commits (1)

1ff9618 fix triple escape in Name

📊 Changes

2 files changed (+32 additions, -8 deletions)

View changed files

📝 proto/src/rr/domain/label.rs (+4 -4)
📝 proto/src/rr/domain/name.rs (+28 -4)

📄 Description

After reviewing some of Name's implementation, it was discovered that Name was not properly decoding octal codes, and instead was performing something very different.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/330 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 1/22/2018 **Status:** ✅ Merged **Merged:** 1/22/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix_name_triple_escape` --- ### 📝 Commits (1) - [`1ff9618`](https://github.com/hickory-dns/hickory-dns/commit/1ff9618a782c270ce44aeb71fc7bc39820d07186) fix triple escape in Name ### 📊 Changes **2 files changed** (+32 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `proto/src/rr/domain/label.rs` (+4 -4) 📝 `proto/src/rr/domain/name.rs` (+28 -4) </details> ### 📄 Description After reviewing some of Name's implementation, it was discovered that Name was not properly decoding octal codes, and instead was performing something very different. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>