mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 03:05:51 +03:00
[GH-ISSUE #44] Crash when creating journal from zone with allow_update=true #330
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#330
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @apexo on GitHub (Sep 8, 2016).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/44
@bluejekyll commented on GitHub (Sep 8, 2016):
I wonder if there's another bug here. It looks like the journal filename is wrong, is it possible that the new journal is empty?
How did you produce this problem?
@apexo commented on GitHub (Sep 8, 2016):
I just used the example config src/config/test/example.toml with the following extra zone:
zones
zone = "example.com"
zone_type = "Master"
file = "example.com.zone"
allow_update = true
@apexo commented on GitHub (Sep 8, 2016):
Before the crash, the journal file does not exist. After the crash, it exists with size 0.
@bluejekyll commented on GitHub (Sep 8, 2016):
Ok, mind fixing another two lines in this? on:
https://github.com/bluejekyll/trust-dns/blob/master/src/named.rs#L94
the set_extension(".jrnl") should be set_extension("jrnl")
and similarly set_extension(".key") should be set_extension("key")
I don't know how I missed that, but I know that I don't have startup tests on the binary. I need to go back and add those. Anyway, if you could make those other changes too that would be awesome. Otherwise I'll do that later.
@apexo commented on GitHub (Sep 8, 2016):
Will do.
@bluejekyll commented on GitHub (Sep 8, 2016):
Thanks for the changes!