[PR #1369] [MERGED] Change Edns set_* to -> &mut Self #2261

New issue

Closed

opened 2026-03-16 08:29:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:29:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1369
Author: @leshow
Created: 1/27/2021
Status: ✅ Merged
Merged: 1/28/2021
Merged by: @bluejekyll

Base: main ← Head: edns_mut_self

📝 Commits (1)

3da4ec7 Change Edns set_* to -> &mut Self

📊 Changes

1 file changed (+11 additions, -7 deletions)

View changed files

📝 crates/proto/src/op/edns.rs (+11 -7)

📄 Description

Interested in this change? All the other set_* methods in Header, Message, Query return &mut Self so they can be chained, except for Edns. Seems like maybe it should also?

I didn't change the now deprecated set_option.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1369 **Author:** [@leshow](https://github.com/leshow) **Created:** 1/27/2021 **Status:** ✅ Merged **Merged:** 1/28/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `edns_mut_self` --- ### 📝 Commits (1) - [`3da4ec7`](https://github.com/hickory-dns/hickory-dns/commit/3da4ec7a05d00d5683993df2f11768ae3220a57b) Change Edns set_* to -> &mut Self ### 📊 Changes **1 file changed** (+11 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/op/edns.rs` (+11 -7) </details> ### 📄 Description Interested in this change? All the other `set_*` methods in `Header`, `Message`, `Query` return `&mut Self` so they can be chained, except for `Edns`. Seems like maybe it should also? I didn't change the now deprecated `set_option`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>