starred/hickory-dns

Fork 0

mirror of https://github.com/hickory-dns/hickory-dns.git synced 2026-04-25 03:05:51 +03:00

[GH-ISSUE #2956] Support building with `std` without `ring` #1101

New issue

Closed

opened 2026-03-16 01:36:26 +03:00 by kerem · 4 comments

kerem commented

2026-03-16 01:36:26 +03:00

Owner

Originally created by @WesleyAC on GitHub (Apr 29, 2025).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2956

Describe the bug

In hickory-proto 0.25.0, it is not possible to build with std features without pulling in ring at the same time. This should be possible.

To Reproduce

hickory-proto = { version = "0.25.1", default-features = false, features = ["std"] }

Expected behavior

A way to build without ring.

System:

Not relavant

Version:
Crate: hickory-proto
Version: 0.25.0, 0.25.1

Additional context

This is a problem for us with Arti, since we can't pull in ring for licensing reasons, and our MSRV is below 1.81, and due to https://github.com/krisprice/ipnet/pull/58, the no_std build of hickory requires rust 1.81+

Originally created by @WesleyAC on GitHub (Apr 29, 2025). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2956 **Describe the bug** In `hickory-proto` 0.25.0, it is not possible to build with `std` features without pulling in `ring` at the same time. This should be possible. **To Reproduce** ``` hickory-proto = { version = "0.25.1", default-features = false, features = ["std"] } ``` **Expected behavior** A way to build without `ring`. **System:** Not relavant **Version:** Crate: hickory-proto Version: 0.25.0, 0.25.1 **Additional context** This is a problem for us with [Arti](https://tpo.pages.torproject.net/core/arti/), since we can't pull in `ring` for licensing reasons, and our MSRV is below 1.81, and due to https://github.com/krisprice/ipnet/pull/58, the no_std build of hickory requires rust 1.81+

kerem closed this issue

2026-03-16 01:36:31 +03:00

kerem commented

2026-03-16 01:36:37 +03:00

Author

Owner

@djc commented on GitHub (Apr 29, 2025):

Can you try main? IIRC we fixed this.

@djc commented on GitHub (Apr 29, 2025): Can you try main? IIRC we fixed this.

kerem commented

2026-03-16 01:36:42 +03:00

Author

Owner

@WesleyAC commented on GitHub (Apr 29, 2025):

AFAICT this is still the case on main, this still results in ring being pulled in:

hickory-proto = { git = "https://github.com/hickory-dns/hickory-dns", default-features = false, features = ["std"], optional = true }

@WesleyAC commented on GitHub (Apr 29, 2025): AFAICT this is still the case on main, this still results in `ring` being pulled in: ```toml hickory-proto = { git = "https://github.com/hickory-dns/hickory-dns", default-features = false, features = ["std"], optional = true } ```

kerem commented

2026-03-16 01:36:47 +03:00

Author

Owner

@divergentdave commented on GitHub (Apr 29, 2025):

I reproduced this locally, using cargo deny check bans in a small project. I also confirmed this was fixed in #2878 -- this was in commit d00f186399.

@divergentdave commented on GitHub (Apr 29, 2025): I reproduced this locally, using `cargo deny check bans` in a small project. I also confirmed this was fixed in #2878 -- this was in commit d00f18639917a9285bc19179d1af1d07270cabd2.

kerem commented

2026-03-16 01:36:52 +03:00

Author

Owner

@WesleyAC commented on GitHub (Apr 29, 2025):

Ah, looks like this is indeed fixed in github.com/hickory-dns/hickory-dns@d00f186399, and I just have a ring dependency coming from another crate I updated as well. Thanks for the info!

@WesleyAC commented on GitHub (Apr 29, 2025): Ah, looks like this is indeed fixed in https://github.com/hickory-dns/hickory-dns/commit/d00f18639917a9285bc19179d1af1d07270cabd2, and I just have a ring dependency coming from another crate I updated as well. Thanks for the info!

kerem referenced this issue

2026-03-16 04:19:23 +03:00

[PR #1108] [MERGED] fix code snippet in resolver README.md #1975