[PR #2200] [CLOSED] move server file configuration parameter to relevant stores - alternative using untagged serde #2878

New issue

Closed

opened 2026-03-16 11:13:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:13:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2200
Author: @divagant-martian
Created: 4/29/2024
Status: ❌ Closed

Base: main ← Head: remove-file-config-shortcut-alterantive

📝 Commits (6)

7364810 move file paramter to relevant stores
91faeaf make stores mandatory since all None paths are error paths
e2e7531 update configuration tests
dd1a0d0 make clippy happy
622035c Revert "update configuration tests"
46231c6 update tests using untagged serde deserialization

📊 Changes

24 files changed (+90 additions, -244 deletions)

View changed files

📝 bin/src/hickory-dns.rs (+7 -68)
📝 bin/tests/named_test_rsa_dnssec.rs (+0 -36)
📝 crates/server/src/config/mod.rs (+16 -10)
📝 crates/server/src/store/config.rs (+1 -1)
📝 crates/server/src/store/file/config.rs (+9 -0)
📝 crates/server/tests/config_tests.rs (+1 -2)
📝 tests/test-data/test_configs/all_supported_dnssec.toml (+7 -7)
📝 tests/test-data/test_configs/dns_over_https.toml (+1 -1)
📝 tests/test-data/test_configs/dns_over_quic.toml (+1 -1)
📝 tests/test-data/test_configs/dns_over_tls.toml (+1 -1)
📝 tests/test-data/test_configs/dns_over_tls_rustls_and_openssl.toml (+1 -1)
📝 tests/test-data/test_configs/dnssec_with_update.toml (+6 -6)
➖ tests/test-data/test_configs/dnssec_with_update_deprecated.toml (+0 -71)
📝 tests/test-data/test_configs/example.toml (+7 -7)
📝 tests/test-data/test_configs/example_allow_networks.toml (+1 -1)
📝 tests/test-data/test_configs/example_deny_allow_networks.toml (+1 -1)
📝 tests/test-data/test_configs/example_deny_networks.toml (+1 -1)
📝 tests/test-data/test_configs/example_forwarder.toml (+7 -7)
📝 tests/test-data/test_configs/example_recursor.toml (+6 -6)
📝 tests/test-data/test_configs/ipv4_and_ipv6.toml (+1 -1)

...and 4 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2200 **Author:** [@divagant-martian](https://github.com/divagant-martian) **Created:** 4/29/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `remove-file-config-shortcut-alterantive` --- ### 📝 Commits (6) - [`7364810`](https://github.com/hickory-dns/hickory-dns/commit/736481041a8d0b7dfd4be61c833682eacb253b28) move file paramter to relevant stores - [`91faeaf`](https://github.com/hickory-dns/hickory-dns/commit/91faeafbe9847da9ac8c0a54c80c78393bb0a646) make stores mandatory since all None paths are error paths - [`e2e7531`](https://github.com/hickory-dns/hickory-dns/commit/e2e7531fbcfb141d552f29cda53755d6180276dd) update configuration tests - [`dd1a0d0`](https://github.com/hickory-dns/hickory-dns/commit/dd1a0d0a19b73c5f9b4936957fe99762924222a6) make clippy happy - [`622035c`](https://github.com/hickory-dns/hickory-dns/commit/622035ce972b1568c9f2e4c825e1cf1df07a1def) Revert "update configuration tests" - [`46231c6`](https://github.com/hickory-dns/hickory-dns/commit/46231c68117de8b2f52b7171272bf2eb1061c301) update tests using untagged serde deserialization ### 📊 Changes **24 files changed** (+90 additions, -244 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/hickory-dns.rs` (+7 -68) 📝 `bin/tests/named_test_rsa_dnssec.rs` (+0 -36) 📝 `crates/server/src/config/mod.rs` (+16 -10) 📝 `crates/server/src/store/config.rs` (+1 -1) 📝 `crates/server/src/store/file/config.rs` (+9 -0) 📝 `crates/server/tests/config_tests.rs` (+1 -2) 📝 `tests/test-data/test_configs/all_supported_dnssec.toml` (+7 -7) 📝 `tests/test-data/test_configs/dns_over_https.toml` (+1 -1) 📝 `tests/test-data/test_configs/dns_over_quic.toml` (+1 -1) 📝 `tests/test-data/test_configs/dns_over_tls.toml` (+1 -1) 📝 `tests/test-data/test_configs/dns_over_tls_rustls_and_openssl.toml` (+1 -1) 📝 `tests/test-data/test_configs/dnssec_with_update.toml` (+6 -6) ➖ `tests/test-data/test_configs/dnssec_with_update_deprecated.toml` (+0 -71) 📝 `tests/test-data/test_configs/example.toml` (+7 -7) 📝 `tests/test-data/test_configs/example_allow_networks.toml` (+1 -1) 📝 `tests/test-data/test_configs/example_deny_allow_networks.toml` (+1 -1) 📝 `tests/test-data/test_configs/example_deny_networks.toml` (+1 -1) 📝 `tests/test-data/test_configs/example_forwarder.toml` (+7 -7) 📝 `tests/test-data/test_configs/example_recursor.toml` (+6 -6) 📝 `tests/test-data/test_configs/ipv4_and_ipv6.toml` (+1 -1) _...and 4 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>