[PR #2327] [MERGED] Return error when no nameservers in resolv.conf #2956

New issue

Closed

opened 2026-03-16 11:17:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:17:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2327
Author: @dav1do
Created: 7/26/2024
Status: ✅ Merged
Merged: 7/27/2024
Merged by: @djc

Base: main ← Head: conf-nameserver-error

📝 Commits (4)

fe42867 fix: return error when resolv_conf has no nameservers
7589360 chore: update resolver tests to include nameserver
dc8f6f3 style: use lowercase error message
18dd40e Merge branch 'main' into conf-nameserver-error

📊 Changes

1 file changed (+15 additions, -17 deletions)

View changed files

📝 crates/resolver/src/system_conf/unix.rs (+15 -17)

📄 Description

Addresses #2042. Raise an error instead of logging a warning if there isn't a nameserver in the resolv.conf and dns queries will never succeed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2327 **Author:** [@dav1do](https://github.com/dav1do) **Created:** 7/26/2024 **Status:** ✅ Merged **Merged:** 7/27/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `conf-nameserver-error` --- ### 📝 Commits (4) - [`fe42867`](https://github.com/hickory-dns/hickory-dns/commit/fe42867c825e4e0d1a99b1391d24b8d9a942f679) fix: return error when resolv_conf has no nameservers - [`7589360`](https://github.com/hickory-dns/hickory-dns/commit/7589360f954cb3d49e825abe6925e71a71080cc5) chore: update resolver tests to include nameserver - [`dc8f6f3`](https://github.com/hickory-dns/hickory-dns/commit/dc8f6f39202af43aa28f1581f5faa47446fd36e9) style: use lowercase error message - [`18dd40e`](https://github.com/hickory-dns/hickory-dns/commit/18dd40e97139e01507470278622b00ced5141532) Merge branch 'main' into conf-nameserver-error ### 📊 Changes **1 file changed** (+15 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/system_conf/unix.rs` (+15 -17) </details> ### 📄 Description Addresses #2042. Raise an error instead of logging a warning if there isn't a nameserver in the resolv.conf and dns queries will never succeed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>