[GH-ISSUE #2904] Remove hickory_proto::rr::rdata::caa::Value #1082

Closed
opened 2026-03-16 01:34:24 +03:00 by kerem · 1 comment
Owner

Originally created by @divergentdave on GitHub (Apr 3, 2025).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2904

PR #2898 stores the original value field of CAA records in the CAA struct. It also keeps around the existing value: Value field for backwards compatibility. When we next make breaking changes, we could eliminate the Value enum to reduce complexity and duplication.

Originally created by @divergentdave on GitHub (Apr 3, 2025). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2904 PR #2898 stores the original value field of CAA records in the `CAA` struct. It also keeps around the existing `value: Value` field for backwards compatibility. When we next make breaking changes, we could eliminate the `Value` enum to reduce complexity and duplication.
kerem 2026-03-16 01:34:24 +03:00
Author
Owner

@divergentdave commented on GitHub (Apr 16, 2025):

PR #2935 similarly stores the original tag field. As a result, unknown tags get stored twice, in both the tag and raw_tag fields. We could remove the String from Property::Unknown, or remove the tag field entirely, and add predicate methods that indicate whether the tag is issue, issuewild, or iodef.

<!-- gh-comment-id:2809947548 --> @divergentdave commented on GitHub (Apr 16, 2025): PR #2935 similarly stores the original tag field. As a result, unknown tags get stored twice, in both the `tag` and `raw_tag` fields. We could remove the `String` from `Property::Unknown`, or remove the `tag` field entirely, and add predicate methods that indicate whether the tag is `issue`, `issuewild`, or `iodef`.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#1082
No description provided.