[PR #2305] [MERGED] dns-test: cache `target` directory across `docker build` invocations #2935

New issue

Closed

opened 2026-03-16 11:16:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:16:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2305
Author: @japaric
Created: 7/10/2024
Status: ✅ Merged
Merged: 7/11/2024
Merged by: @pvdrz

Base: main ← Head: ja-cache-target-dir-across-docker-builds

📝 Commits (1)

ce9bb17 dns-test: cache target directory across docker build invocations

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 conformance/packages/dns-test/src/docker/hickory.Dockerfile (+2 -1)

📄 Description

whenever the hickory-dns source is modified, the dns-test-hickory image needs to be updated to contain the latest cargo build of hickory-dns.

so far, that process has been done entirely from scratch. that results in long wait times whenever one modifies hickory-dns and then runs the conformance-tests (or the explore example).

this commit sets up a target directory that is shared by all instances of docker build hickory.Dockerfile. this results in hickory-dns not being build from scratch everytime but rather from whatever artifacts were produced in the last docker build -- pretty much emulating how cargo build works when run outside docker build -- and this greatly improves the wait time of the "modify hickory; re-run conformance tests" workflow.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2305 **Author:** [@japaric](https://github.com/japaric) **Created:** 7/10/2024 **Status:** ✅ Merged **Merged:** 7/11/2024 **Merged by:** [@pvdrz](https://github.com/pvdrz) **Base:** `main` ← **Head:** `ja-cache-target-dir-across-docker-builds` --- ### 📝 Commits (1) - [`ce9bb17`](https://github.com/hickory-dns/hickory-dns/commit/ce9bb17873521469a572381baa7e46a1fbda44c1) dns-test: cache `target` directory across `docker build` invocations ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/dns-test/src/docker/hickory.Dockerfile` (+2 -1) </details> ### 📄 Description whenever the `hickory-dns` source is modified, the `dns-test-hickory` image needs to be updated to contain the latest `cargo build` of `hickory-dns`. so far, that process has been done entirely from scratch. that results in long wait times whenever one modifies `hickory-dns` and then runs the `conformance-tests` (or the `explore` example). this commit sets up a `target` directory that is shared by all instances of `docker build hickory.Dockerfile`. this results in `hickory-dns` not being build from scratch everytime but rather from whatever artifacts were produced in the last `docker build` -- pretty much emulating how `cargo build` works when run outside `docker build` -- and this greatly improves the wait time of the "modify hickory; re-run conformance tests" workflow. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>