[PR #41] [MERGED] Correctly handle null return of disk resize endpoint #95

New issue

Closed

opened 2026-03-03 15:30:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/41
Author: @jqueuniet
Created: 1/13/2023
Status: ✅ Merged
Merged: 1/13/2023
Merged by: @luthermonson

Base: main ← Head: fix_resize_return

📝 Commits (2)

6aa0bf6 Correctly handle null return of ResizeDisk
323ae52 Remove unused upid variable

📊 Changes

1 file changed (+3 additions, -5 deletions)

View changed files

📝 virtual_machines.go (+3 -5)

📄 Description

I made a mistake yesterday, the resize endpoint does not return a task but a null value as it is a synchronous operation.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/41 **Author:** [@jqueuniet](https://github.com/jqueuniet) **Created:** 1/13/2023 **Status:** ✅ Merged **Merged:** 1/13/2023 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `fix_resize_return` --- ### 📝 Commits (2) - [`6aa0bf6`](https://github.com/luthermonson/go-proxmox/commit/6aa0bf6b54b9ace3157f25444ad2e8c01b294514) Correctly handle null return of ResizeDisk - [`323ae52`](https://github.com/luthermonson/go-proxmox/commit/323ae52af2f98c2f6ca9c1b4c15b1f9958158bf3) Remove unused upid variable ### 📊 Changes **1 file changed** (+3 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `virtual_machines.go` (+3 -5) </details> ### 📄 Description I made a mistake yesterday, the resize endpoint does not return a task but a null value as it is a synchronous operation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>