mirror of
https://github.com/luthermonson/go-proxmox.git
synced 2026-04-26 09:25:53 +03:00
[GH-ISSUE #171] VirtualMachine states are broken since removing QMPStatus conditions #41
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/go-proxmox#41
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rybnico on GitHub (Oct 8, 2024).
Original GitHub issue: https://github.com/luthermonson/go-proxmox/issues/171
The fix for #139 (#166) breaks some VirtualMachine state functions.
Since the value of
QMPStatusis not taken into account, the following functions are no longer reliable:IsRunningreturnstrueeven if the VirtualMachine is paused.IsPausedreturnstrueeven if the VirtualMachine is running (my fix in #169 is wrong because there is nopausedstate).IsStoppedreturnstrueeven if the VirtualMachine is hibernated.See PR #170
@rybnico commented on GitHub (Oct 19, 2024):
Fixed by #170
@luthermonson Would you mind releasing a version with this fix?
@luthermonson commented on GitHub (Oct 19, 2024):
sure let me do it now
@luthermonson commented on GitHub (Oct 19, 2024):
https://github.com/luthermonson/go-proxmox/releases/tag/v0.2.1