[PR #95] [MERGED] fix node network deserialization #145

New issue

Closed

opened 2026-03-03 15:30:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:30:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/luthermonson/go-proxmox/pull/95
Author: @simplysoft
Created: 10/15/2023
Status: ✅ Merged
Merged: 10/17/2023
Merged by: @luthermonson

Base: main ← Head: fix/node-networks

📝 Commits (1)

50cd9d4 fix node network deserialization

📊 Changes

6 files changed (+210 additions, -4 deletions)

View changed files

📝 nodes_network_test.go (+29 -1)
📝 tests/mocks/main.go (+6 -0)
📝 tests/mocks/pve7x/nodes.go (+58 -0)
➕ tests/mocks/pve8x/nodes.go (+109 -0)
➕ tests/mocks/pve8x/proxmox.go (+5 -0)
📝 types.go (+3 -3)

📄 Description

& test fixtures / mocks for PVE 7.3.3 and 8.0.4

it looks like PVE is not fully adhering to what is specified in their rest api documentation

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/luthermonson/go-proxmox/pull/95 **Author:** [@simplysoft](https://github.com/simplysoft) **Created:** 10/15/2023 **Status:** ✅ Merged **Merged:** 10/17/2023 **Merged by:** [@luthermonson](https://github.com/luthermonson) **Base:** `main` ← **Head:** `fix/node-networks` --- ### 📝 Commits (1) - [`50cd9d4`](https://github.com/luthermonson/go-proxmox/commit/50cd9d4baf44a256c033bdfecbcc01be87a67f3d) fix node network deserialization ### 📊 Changes **6 files changed** (+210 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `nodes_network_test.go` (+29 -1) 📝 `tests/mocks/main.go` (+6 -0) 📝 `tests/mocks/pve7x/nodes.go` (+58 -0) ➕ `tests/mocks/pve8x/nodes.go` (+109 -0) ➕ `tests/mocks/pve8x/proxmox.go` (+5 -0) 📝 `types.go` (+3 -3) </details> ### 📄 Description & test fixtures / mocks for PVE 7.3.3 and 8.0.4 it looks like PVE is not fully adhering to what is specified in their rest api documentation --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 15:30:24 +03:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/go-proxmox#145

No description provided.

Rows
Columns