[PR #229] [MERGED] fix: handle player loop channels closure #258

Closed
opened 2026-02-28 14:26:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/229
Author: @devgianlu
Created: 10/14/2025
Status: Merged
Merged: 10/14/2025
Merged by: @devgianlu

Base: masterHead: fix-223


📝 Commits (1)

  • d9fb778 fix: handle player loop channels closure

📊 Changes

1 file changed (+30 additions, -6 deletions)

View changed files

📝 cmd/daemon/player.go (+30 -6)

📄 Description

Previously, if any of the channels were to close we would handle a zero value of the channel type. This can be a nil pointer or a zeroed struct.

Fixes #223


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/229 **Author:** [@devgianlu](https://github.com/devgianlu) **Created:** 10/14/2025 **Status:** ✅ Merged **Merged:** 10/14/2025 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `fix-223` --- ### 📝 Commits (1) - [`d9fb778`](https://github.com/devgianlu/go-librespot/commit/d9fb77807a97ea22f184bbdb5e922e51422bc755) fix: handle player loop channels closure ### 📊 Changes **1 file changed** (+30 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `cmd/daemon/player.go` (+30 -6) </details> ### 📄 Description Previously, if any of the channels were to close we would handle a zero value of the channel type. This can be a nil pointer or a zeroed struct. Fixes #223 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:26:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/go-librespot#258
No description provided.