[PR #261] [MERGED] fix: unset Zeroconf user on restore error to allow takeover #276

Closed
opened 2026-02-28 14:26:30 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/261
Author: @devgianlu
Created: 11/30/2025
Status: Merged
Merged: 11/30/2025
Merged by: @devgianlu

Base: masterHead: fix-240


📝 Commits (1)

  • beca59f fix: unset Zeroconf user on restore error to allow takeover

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 cmd/daemon/main.go (+3 -0)

📄 Description

Fixes #240, supersedes #258

If we fail to restore the previous session when a user disconnects, unset the current Zeroconf user so that it can login again.

Without this, we would just return without actually attempting:
github.com/devgianlu/go-librespot@84f10376c1/zeroconf/zeroconf.go (L185-L194)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/261 **Author:** [@devgianlu](https://github.com/devgianlu) **Created:** 11/30/2025 **Status:** ✅ Merged **Merged:** 11/30/2025 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `fix-240` --- ### 📝 Commits (1) - [`beca59f`](https://github.com/devgianlu/go-librespot/commit/beca59f90b93a4cc341bcce7ef0b2dc8475d734b) fix: unset Zeroconf user on restore error to allow takeover ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `cmd/daemon/main.go` (+3 -0) </details> ### 📄 Description Fixes #240, supersedes #258 If we fail to restore the previous session when a user disconnects, unset the current Zeroconf user so that it can login again. Without this, we would just return without actually attempting: https://github.com/devgianlu/go-librespot/blob/84f10376c135a10580f551d31917197e283cf2f7/zeroconf/zeroconf.go#L185-L194 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:26:30 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/go-librespot#276
No description provided.