[PR #139] [CLOSED] fix: avoid popping noise when changing volume #229

New issue

Closed

opened 2026-02-28 14:26:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/139
Author: @aykevl
Created: 11/9/2024
Status: ❌ Closed

Base: master ← Head: alsa-volume-ramp

📝 Commits (1)

7354f1e fix: avoid popping noise when changing volume

📊 Changes

1 file changed (+26 additions, -6 deletions)

View changed files

📝 output/driver-alsa.go (+26 -6)

📄 Description

Just a little pet peeve of mine. When the volume changes (or is muted/unmuted), a little pop can be heard due to the sudden change. This can be fixed by smoothly increasing/decreasing the volume.

This noise is especially audible on tracks like this one: https://www.youtube.com/watch?v=eH-5U7GeofA

Weirdly, PulseAudio and PipeWire don't seem to do this internally. Maybe I'll send a patch to PipeWire to fix this, because it's a bit annoying (and there's not much we can do about it in the PulseAudio driver apart from managing volume ourselves).

So far this is an experiment, and there's a TODO I'd need to fix get this ready for review. But if this is something you'd be interested in, I can continue working on it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/139 **Author:** [@aykevl](https://github.com/aykevl) **Created:** 11/9/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `alsa-volume-ramp` --- ### 📝 Commits (1) - [`7354f1e`](https://github.com/devgianlu/go-librespot/commit/7354f1e8539dd5680c34f902aecc995ac5915ad9) fix: avoid popping noise when changing volume ### 📊 Changes **1 file changed** (+26 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `output/driver-alsa.go` (+26 -6) </details> ### 📄 Description Just a little pet peeve of mine. When the volume changes (or is muted/unmuted), a little pop can be heard due to the sudden change. This can be fixed by smoothly increasing/decreasing the volume. This noise is especially audible on tracks like this one: https://www.youtube.com/watch?v=eH-5U7GeofA Weirdly, PulseAudio and PipeWire don't seem to do this internally. Maybe I'll send a patch to PipeWire to fix this, because it's a bit annoying (and there's not much we can do about it in the PulseAudio driver apart from managing volume ourselves). --- So far this is an experiment, and there's a TODO I'd need to fix get this ready for review. But if this is something you'd be interested in, I can continue working on it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>