mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 14:16:12 +03:00
[GH-ISSUE #81] Icons not being preserved #81
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#81
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Lantizia on GitHub (Apr 10, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/81
Software versions
Steps to reproduce
Expected outcome
It to sync up properly and down properly?
Actual outcome
When all the bookmarks got downloaded on the work PC... none of them had any bookmark icons any more. This would be very nice as things are just a lot more easy to recognise with the icons... I even use an extension to manually set icons sometimes so that the bookmark doesn't even need a name (a string of just "") so it can take less room on the bookmarks bar and just be recognisable by icon alone.
@marcelklehr commented on GitHub (Apr 10, 2018):
Good point! This is currently not possible with the webextensions API, but the browser should usually populate the icons automatically, once you visit the URLs.
@Lantizia commented on GitHub (Apr 10, 2018):
Visiting 2500 bookmarks? :D
Nah, so perhaps is there a way of storing the image in the Bookmarks App database? Maybe base64 encoded? Would this be better as a Bookmarks App issue first?
Also if you mean the Chrome extension itself can't read/write image information for native bookmarks... then it must be able to as I use this extension which can... http://chrome.google.com/webstore/detail/acmfnomgphggonodopogfbmkneepfgnh
@marcelklehr commented on GitHub (Apr 10, 2018):
Mmmh. Interesting. I have no idea how they pull that off.
@marcelklehr commented on GitHub (Jun 21, 2018):
A possibility would be to load the bookmark url in the background on creation somehow. I will look into this when I have time. It's not a priority for me at the moment.
@marcelklehr commented on GitHub (Aug 30, 2018):
just fyi, I just found this extension by chance which allows you to reload the favicons of your bookmarks: https://addons.mozilla.org/en-US/firefox/addon/checkmarks-web-ext
Just until I get around to implementing this in floccus itself :)
@Lantizia commented on GitHub (Oct 11, 2018):
Lo,
Just wanted to say that I've been temporarily storing URLs in a text file for the last couple of months while I re-install a few machines until I get settled again. Just installed the new floccus (using the XBEL method) and seems to be working great.
Have also restarted the liberapay thingy - apparently it went a bit odd with their payment processor a while back.
I was wondering (in terms of this issue), if perhaps since the DTD for XBEL has stayed stagnant for a while... if floccus is now the most prominent use of it?
If it is stagnant (or perhaps if we can reach out to the maintainers of it for a comment on that?)... then maybe we can work on a 1.2 version (there already seems to be 1.1 - but I can't find the DTD for it... and floccus is using 1.0)... where we could add in some mechanism for recording the icons as base64 or something.
As mentioned before, browser extensions (like Bookmark Favicon Changer) do have the ability to read and even change favicons associated with bookmarks - so some mechanism must exist.
Thanks for all the hard work guys.
:)
@marcelklehr commented on GitHub (Aug 1, 2020):
I think this is borderline out of scope for this project. It's probably a nice feature, but not something I prioritize. I'm closing this for now.
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.