mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 14:16:12 +03:00
[GH-ISSUE #1115] floccus not sync favicon between client of Firefox #743
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#743
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tomergam on GitHub (Apr 14, 2022).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1115
Which version of floccus are you using?
Firefox 99.0.1 (64-bit) - Windows
Sync method
{"label"=>"Nextcloud Bookmarks"}
Which browser are you using?
Firefox 99.0.1 (64-bit)
Which version of Nextcloud Bookmarks are you using? (if relevant)
No response
Which version of Nextcloud? (if relevant)
v23.0.2
What kind of WebDAV server are you using? (if relevant)
No response
Describe the Bug
favicon is not sync between firefox client,
there is globe icon, only after opening the URL, the favicon showing
Expected Behavior
the favicon should appear in you environment after full sync
To Reproduce
Installed new clean browser with floccus extension
Debug log provided
@marcelklehr commented on GitHub (Apr 14, 2022):
Yep, this is a known limitation. (I should probably add this to the FAQ.) Also see #81 where this was first reported.
@cracket commented on GitHub (Sep 26, 2022):
I will have to counter this bug, because I have observed something opposite.
I have pulled my bookmarks from webdav using floccus 4.17.1 on firefox esr 102.3.0 fresh installation.
Synchronization of thousands of items took 15 minutes. Half hour after synchronization machine was still experiencing heavy network traffic without any browser activity. I was shocked because FF was downloading every single favicon from the internet for each new bookmark that was pulled, and after another half hour every "globe" icon was replaced with original one.
So after some time firefox did synced favicons on it's own extremely slowing down my network connectivity.
This is obviously not a bug of floccus as far as I can see, but limitation of xbel. But if you discuss it - make sure you take into account privacy&performance impact related to it:
I recommend also reading a bug report from mozilla about favicons and impact of caching them:
https://bugzilla.mozilla.org/show_bug.cgi?id=1618257
which suggests that even if floccus synced favicons, ff would ignore the cache and reload favicons directly
There is also nice document mentioned there about favicon based fingerprinting
https://www.cs.uic.edu/~polakis/papers/solomos-ndss21.pdf
So I suggest keeping this issue "On hold" and participating in discussion about firefox behavior on favicons.
@marcelklehr commented on GitHub (Oct 7, 2022):
Thanks for the insights @cracket. I will close this issue in light of this.
@github-actions[bot] commented on GitHub (Oct 8, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.