mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 22:26:06 +03:00
[GH-ISSUE #70] Trying to create a URL that is already bookmarked. #69
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#69
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @SomePoorBastard on GitHub (Apr 3, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/70
Software versions
Steps to reproduce
Expected outcome
Expected that if a bookmark was already present on the server that that bookmark's information would be read { id, url, hash, etc... }, then updated locally
...
Actual outcome
I got a nice, pretty exception message :-)
...
Browser Log Trace
@marcelklehr commented on GitHub (Apr 3, 2018):
Is the bookmark that is about to be duplicated the same that had been involved in the SERVERUPDATE, or is it a random one?
@SomePoorBastard commented on GitHub (Apr 3, 2018):
I'll have to check the logs again for that. I believe it was from the same site uri, but may have had a different query parameter at the end. Expect an update in a few hours.
@SomePoorBastard commented on GitHub (Apr 3, 2018):
I've repeated the steps as is, and left the actual URL for one example of where the duplicate bookmarks are in play. I've tried to keep with the best understanding I have of the general sync "session", intact:
@marcelklehr commented on GitHub (Apr 6, 2018):
Is that a sync from scratch? If so the log would indicate that you have only 3 bookmarks in the sync folder, but 500 on the server. Is that correct?
@SomePoorBastard commented on GitHub (Apr 7, 2018):
This was not a sync from scratch; I left the bookmark structure on the server and the client alone.
Bookmarks were already present on both sides; a dirty sync. In the session above, I removed the account in Floccus, removed the Floccus addon, then installed again. The account settings were set to (Server URL as [https://nextcloud.example.com] Username as [SomePoorBastard], Password as [$ecr3t], Sync Folder as "/").
I believe what happened is a previous Floccus install created a new root directory ["/"] if one did not exist, then begin synchronization. After synchronization, I removed Floccus, then made some modifications on the client side. Then, I reinstalled Floccus (2.0.5). I think Floccus used the existing directory folder and assumed it was empty, and then ran into errors.
To fix it, what I ended up doing at this point was the following:
The log for the synchronization steps above may be found here (for thirty days past 4/7/2018): https://pastebin.com/puBkKbYn
Then, I looked in chrome://bookmarks and saw this as my folder structure:
Before it was just:
I have a feeling this is related to Issue #69, but am not positive. This was not the end state I wanted (as there were bookmarks scattered through each of the directories under Root>Bookmarks bar), so I blew away all the bookmarks on the server through the Bookmarks App UI, then imported them through the backup export I made previously.
@marcelklehr commented on GitHub (Apr 7, 2018):
So, the end state you describe looks like you forgot to set the correct sync folder after reinstalling floccus, so it ended up creating a new folder for the new account (//Bookmarks bar/Nextcloud), where it created the directories that are on the server (e.g. //Bookmarks bar/Nextcloud ... /Bookmarks bar). You could try removing /Bookmarks bar/Nextcloud and setting the sync folder to //. If you happen to sync across different browsers this will make you run into #69, though.
EDIT: By syncing from scratch I mean the first sync for an account, when floccus has to setup everything. "I removed the account in Floccus, removed the Floccus addon, then installed again" sounds like a sync from scratch, which would mean that a folder with only 3 bookmarks was selected as the sync folder.
@SomePoorBastard commented on GitHub (Apr 8, 2018):
I would agree with your assessment above. I've switched between the default and explicitly configuring as / between upgrades/reinstalls enough that I don't recall making that folder change. Couple of questions before I would motion for a close.
2a. Manufacturer (Microsoft, Apple, Google, Mozilla)
2b. Versions within a manufacturer?
2c. Different instances of the same version? On a different host or same host?
(Side note: I've began to favor Floccus on Chrome as I've felt and seen frustration with the way Firefox breaks for no apparent reason.)
@marcelklehr commented on GitHub (Apr 8, 2018):
//, when the path is longer. It might be a good idea to normalize that into/. I just confirmed, that when you set the a folder there's no trailing slash, so it's/for the root folder (was confused there for a second). Internally the sync folder is not represented by a path, but by the folder id, so there's not much that can go wrong, when setting the folder using the picker. ;)@SomePoorBastard commented on GitHub (Apr 9, 2018):
Alright. I'll need to pay attention to the folder setup next time.
tldr; User should keep root folder setting consistent to avoid issues with upgrading and reinstalling.
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.