mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 22:26:06 +03:00
[GH-ISSUE #73] Empty options panel #70
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#70
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mobamoba on GitHub (Apr 5, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/73
Software versions
Steps to reproduce
Expected outcome
...
Actual outcome
...
Floccus hangs after some period of time. The syncing symbol appears on the icon, but clicking it brings up nothing. The Options menu also brings up nothing other than the main description page. Here's the debug log:
Error: Could not establish connection. Receiving end does not exist. undefined
Error: Invalid tab ID: 119 ext-browser.js
Error: Invalid tab ID: 122 ext-browser.js
Error: Could not establish connection. Receiving end does not exist. undefined
Unknown property ‘enable-background’. Declaration dropped. container-edit.svg
Unknown property ‘enable-background’. Declaration dropped. container-delete.svg
Error: Could not establish connection. Receiving end does not exist. undefined
TypeError: can't access dead object[Learn More] core.js:682:17
Error: Could not establish connection. Receiving end does not exist. undefined
@marcelklehr commented on GitHub (Apr 5, 2018):
Mmmh. Any CPU load? Does disabling and enabling the addon help?
@mobamoba commented on GitHub (Apr 5, 2018):
Yeah there was some CPU load but with Firefox it's difficult to tie to a particular addon. And disabling/enabling didn't help.
@mobamoba commented on GitHub (Apr 6, 2018):
I've narrowed this down a bit. Floccus is incompatible with Firefox Sync for some reason even when sync isn't syncing Bookmarks. In other words, having Sync turned on, even if it's doing nothing other than syncing open browser tabs, will at some point hang Floccus. When Sync gets stuck in a loop of some kind (which it seems to quite often), Floccus hangs.
I'm not sure why these two things are connected as all other addons work fine regardless of what Sync is doing but that's pretty much what I've narrowed it down to.
@marcelklehr commented on GitHub (Apr 6, 2018):
It could be that Sync temporarily stops some API interactions. If it get stuck in a loop as you described, the bookmarks API will be blocked forever and so will floccus. I recommend using either Sync or Floccus even though I realize that floccus doesn't offer the full set of features of Firefox Sync. :/
(Closing this for now. Feel free to reopen!)
@mobamoba commented on GitHub (Apr 7, 2018):
I think we should reopen. Firefox sync is disabled and Firefox restarted, Floccus is up to 2.0.6. Same problem. And unfortunately same lack of debugging information,
@marcelklehr commented on GitHub (Apr 18, 2018):
Do you have a lot of bookmarks? Maybe it's not actually hanging, but lagging extremely. I've experienced poor performance in Firefox before.
@mobamoba commented on GitHub (Apr 19, 2018):
Not really - 700 or so? I don't think it's lag. I've just left it off hoping that maybe a new version would magically fix the problem. :)
@dotancohen commented on GitHub (Apr 30, 2018):
I'm experiencing a similar issue, but I have what some people would call a lot of bookmarks.
Firefox hangs often since installing Floccus.
Clicking the Floccus icon just opens an empty bubble.
Adding a new bookmark to the sync folder freezes up my entire system for about half a minute.
The options page sometimes shows my credentials, and sometimes shows only the main description text.
I've tried disabling all other addons (Tridactyl, Tree Style Tabs) but that did not help.
Firefox Sync is disabled, I do not have a Firefox account logged in to the browser.
CentOS Linux 7.3, Firefox 59.0.2 downloaded from Mozilla.
I'm happy to help if I can provide any more information.
@marcelklehr commented on GitHub (May 1, 2018):
Does this happen even with the latest version (v2.1.0)?
Same here. It shouldn't freeze immediately in the latest version, but only after a timeout of inactivity.
In general v2.1.0 should be much more performant, especially on firefox, as their APIs are way slower.
@dotancohen commented on GitHub (May 2, 2018):
@dotancohen commented on GitHub (May 2, 2018):
@exekutive commented on GitHub (May 2, 2018):
I have the same symptom as dotancohen. Just a blank bubble.
Nextcloud 13.0.2
Bookmarks app 0.11.0
floccus 2.1.0
Firefox sync disabled
I tried disabling + enabling the addon
@marcelklehr commented on GitHub (May 9, 2018):
Please try v2.2.0 to check whether this is still an issue in the latest version.
@dotancohen commented on GitHub (May 10, 2018):
Thank you, it does seem that v2.2.0 works fine and is not hanging.
Note that the hang may have been due to one of a few issues which I've identified:
I've changed my Nextcloud URL from http to https, and though I updated that in the Floccus settings, it seems to not have been saved in Floccus. I could not know that with 2.1, as the UI for the server config would often be not displayed. With v2.2 I saw the issue and immediately corrected it.
I actually have many more bookmarks than previously stated. Though I found ~4000 bookmarks synced to NC, in places.sqlite I see quite a few more, but v2.2 is handling them fine:
@dotancohen commented on GitHub (May 10, 2018):
I spoke too soon. After about an hour of syncing, during which ~9000 bookmarks have been transfered to the server, Firefox is using a bit over 100% CPU (8 core CentOS desktop) and over 2 GiB of RAM (with electrolosys - multiprocess firefox - it is difficult to say exactly). The whole system is sluggish. With another ~10,000 bookmarks to go I'm afraid of stability and there seems to be no way to cancel a running sync.
Disabling Floccus while the system was sluggish immediately restored system performance and Firefox resource usage.
@marcelklehr commented on GitHub (May 13, 2018):
Mh. I'd say it wasn't designed to sync ~30000 bookmarks :D But then it's slow even for 3000 which is my current testing benchmark. I'll investigate.
Your miraculous multiplication of bookmarks could be due to some bookmarks being stuck in the root folder of your browser, where you can't see them. :/
@marcelklehr commented on GitHub (May 13, 2018):
Am I correct in assuming that the "empty bubble" problem is gone now, though?
@dotancohen commented on GitHub (May 14, 2018):
No. It was gone in 2.2.0, but in 2.2.2 I get only the bubble.
Furthermore, even though I keep deleting them and even had to manually delete them from the
browser-extension-data/floccus@handmadeideas.org/storage.jsfile, I keep getting the foo@http://ba.r folder recreated. No, I am not pressing the "test" button, as I cannot get to it due to the bubble!I have tried disabling all other extensions (notably Tree Style Tabs and Vimperator) with no change in behaviour.
@dotancohen commented on GitHub (May 14, 2018):
Actually, the number is accurate. I've been using Nutscrape, Opera, and then Firefox since 1998 or so. The number seems about right, I should check to see how many are still valid! In fact, I will do that.
@dotancohen commented on GitHub (May 14, 2018):
Reverting to 2.2.0 and restarting Firefox did not resolve the issue. So it is not a problem with 2.2.2, and I'm returning to that version.
@marcelklehr commented on GitHub (May 14, 2018):
@dotancohen Uff. 20 years of bookmarks. 😱
Mh, could you try the following:
Firefox
about:debuggingdebugbutton next to floccus entry and confirm the dialogbrowser.storage.local.set({'accounts':{}})and press run to revert your accounts@dotancohen commented on GitHub (May 14, 2018):
Thank you, here are the logs:
https://pastebin.com/6E2Q4JVg
Note that the fake "foo" account shows repeatedly, yet the real Nextcloud account does not show at all.
@dotancohen commented on GitHub (May 14, 2018):
I have now completely removed Floccus, restarted Firefox, and reinstalled 2.2.2 from AMO. I'll report back with the results.
@dotancohen commented on GitHub (May 14, 2018):
With the new install:
@marcelklehr commented on GitHub (May 14, 2018):
What do you mean by "created"? Are they visible in the floccus options panel or do you only see the folders? The folders you can safely delete. (The former shouldn't be possible at all, since those active dummy accounts were the reason you got the empty bubble in the first place :) )
@marcelklehr commented on GitHub (May 14, 2018):
The first phase of the sync only stresses the server. The heavy lifting for your firefox instance comes at the end ;)
@dotancohen commented on GitHub (May 15, 2018):
I mean that I see their folders in the Bookmarks, nothing else. I should have been clearer.
After letting Floccus run all night, I see that I have 23589 bookmarks on the server. That is about 3000 bookmarks short of what Firefox is holding, but I understand that Floccus with not store dupes as it does not support folders.
Server:
Desktop:
I converted all times to UTC so that they could be compared. The server is an AWS T2.small, but the accrued CPU burst credits seem to have been enough.
@marcelklehr commented on GitHub (May 18, 2018):
If your browser is not in %user then this still doesn't look good, but as expected, per %system. If the %system burst is not from your browser, then this looks remarkably good.
@marcelklehr commented on GitHub (May 18, 2018):
@mobamoba Any news on your end?
@mobamoba commented on GitHub (May 18, 2018):
For me things have been working perfectly for the last few versions. At some point, I started a new Firefox profile and that solved the problem I think.
@dotancohen commented on GitHub (May 22, 2018):
Yes, of course the browser is in %user. Note that the browser is on the Desktop, which only hit ~12.
@marcelklehr commented on GitHub (May 23, 2018):
Well, in that case: Happy syncing to you and thanks for the feedback :)
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.