[PR #1285] [MERGED] Support Node v18 for build #1848

New issue

Closed

opened 2026-02-25 23:31:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:31:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/floccusaddon/floccus/pull/1285
Author: @heapifyman
Created: 11/13/2022
Status: ✅ Merged
Merged: 11/13/2022
Merged by: @marcelklehr

Base: develop ← Head: fix/1284-instructions-in-setting-up-a-dev-environment-are-not-working

📝 Commits (1)

8e8698f closes #1284

📊 Changes

4 files changed (+24 additions, -17 deletions)

View changed files

📝 README.md (+10 -10)
📝 package-lock.json (+9 -2)
📝 package.json (+1 -1)
📝 webpack.common.js (+4 -4)

📄 Description

closes #1284

Remove dependency "fibers", which does not work with node 16 and above - see https://github.com/laverdet/node-fibers#readme.

Disable use of "fibers" in "sass-loader" according to https://webpack.js.org/loaders/sass-loader/#string.

Update instructions to setup development environment in README. It should be possible to build the project with nodejs 18 (current LTS version) now.

I've tried npm run build and npm run watch, and both succeeded with out errors. I haven't tried actually running the project in Android Studio, for example.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/floccusaddon/floccus/pull/1285 **Author:** [@heapifyman](https://github.com/heapifyman) **Created:** 11/13/2022 **Status:** ✅ Merged **Merged:** 11/13/2022 **Merged by:** [@marcelklehr](https://github.com/marcelklehr) **Base:** `develop` ← **Head:** `fix/1284-instructions-in-setting-up-a-dev-environment-are-not-working` --- ### 📝 Commits (1) - [`8e8698f`](https://github.com/floccusaddon/floccus/commit/8e8698f8b5daf301f302444e57bbdceb6d33e576) closes #1284 ### 📊 Changes **4 files changed** (+24 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+10 -10) 📝 `package-lock.json` (+9 -2) 📝 `package.json` (+1 -1) 📝 `webpack.common.js` (+4 -4) </details> ### 📄 Description closes #1284 Remove dependency "fibers", which does not work with node 16 and above - see https://github.com/laverdet/node-fibers#readme. Disable use of "fibers" in "sass-loader" according to https://webpack.js.org/loaders/sass-loader/#string. Update instructions to setup development environment in README. It should be possible to build the project with nodejs 18 (current LTS version) now. I've tried `npm run build` and `npm run watch`, and both succeeded with out errors. I haven't tried actually running the project in Android Studio, for example. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>