[PR #1846] [MERGED] Separators on Bookmarks-bar are Vertical rather than Horizontal #1943

New issue

Closed

opened 2026-02-25 23:31:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:31:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/floccusaddon/floccus/pull/1846
Author: @macrogreg
Created: 1/27/2025
Status: ✅ Merged
Merged: 2/1/2025
Merged by: @marcelklehr

Base: develop ← Head: bookmarks-bar-separators

📝 Commits (10+)

0f99ec6 Titles of horizontal separators are better visible consecutive lines.
67d30bb Create vertical separators on the Bookmarks Bar
6f95334 Tests for vertical separators on the Bookmarks Bar
785f2a7 Translate _locales/en/messages.json in zh_CN
a199cb7 Fix typos
1341d31 For local development for Firefox.
9e3eacd Merge pull request #1848 from peter-lyons-kehl/manifest-firefox-override
b9a2add Fix indentation
d81610c Fix trailing spaces
b64822a Fix link issues in files unrelated to overall change

📊 Changes

8 files changed (+188 additions, -39 deletions)

View changed files

📝 CHANGELOG.md (+5 -0)
📝 _locales/zh_CN/messages.json (+2 -2)
➕ manifest-firefox-override.sh (+30 -0)
📝 package.json (+3 -0)
📝 src/lib/browser/BrowserTree.ts (+20 -9)
📝 src/test/test.js (+122 -22)
📝 src/ui/components/AccountCard.vue (+4 -4)
📝 src/ui/components/OptionsGoogleDrive.vue (+2 -2)

📄 Description

This PR addresses https://github.com/floccusaddon/floccus/issues/1841:

Firefox supports bookmark separator lines as a first-class concept, but other supported browsers do not. Fluccus mitigates that by creating dummy bookmarks looking like horizontal lines. This change ensures that when such dummy bookmarks are created in the Bookmark Toolbar, vertical rather than horizontal lines are used.

Validation:

Added a unit test that exercises the new logic (should convert vertical and horizontal separators).
Manual validation by creating bookmarks and separators in different folders in Firefox, observing them being correctly synced to Edge, then being modified in Edge, and the changed being correctly synched back to Firefox.

Other changes:

Add npm scripts to build under Windows.
Improve view of horizontal dummy separators by making them consecutive, slightly longer lines.
Fix a couple lint failures in random/unrelated files.

Note:

There appears to be a sync/diff issues with _locales/zh_CN/messages.json and manifest-firefox-override.sh. The files are identical to the develop branch, but a modification is being picked up. I think this was caused during cross-repo merges by multiple people somehow. A merge has not resolved that. To work around, let's merge this PR and subsequently manually validate that those files have the expected contents. If there are any issue, we will fix those contents in a separate PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/floccusaddon/floccus/pull/1846 **Author:** [@macrogreg](https://github.com/macrogreg) **Created:** 1/27/2025 **Status:** ✅ Merged **Merged:** 2/1/2025 **Merged by:** [@marcelklehr](https://github.com/marcelklehr) **Base:** `develop` ← **Head:** `bookmarks-bar-separators` --- ### 📝 Commits (10+) - [`0f99ec6`](https://github.com/floccusaddon/floccus/commit/0f99ec600aadeb74d9a5f882e37aa140b67a0b1d) Titles of horizontal separators are better visible consecutive lines. - [`67d30bb`](https://github.com/floccusaddon/floccus/commit/67d30bb42fae7acf1582dd11ef444a27d643d522) Create vertical separators on the Bookmarks Bar - [`6f95334`](https://github.com/floccusaddon/floccus/commit/6f95334a965a373dcb497ec39dd29d4e07d63852) Tests for vertical separators on the Bookmarks Bar - [`785f2a7`](https://github.com/floccusaddon/floccus/commit/785f2a7af16df6375139d187fe7a016301a9472a) Translate _locales/en/messages.json in zh_CN - [`a199cb7`](https://github.com/floccusaddon/floccus/commit/a199cb7c707804065889c5f92d1992535a0ab440) Fix typos - [`1341d31`](https://github.com/floccusaddon/floccus/commit/1341d31f7bc5a60842fed6e4d7c8cbecfda724e9) For local development for Firefox. - [`9e3eacd`](https://github.com/floccusaddon/floccus/commit/9e3eacd2b1c3d0472fa331fdebdca769854a3d6e) Merge pull request #1848 from peter-lyons-kehl/manifest-firefox-override - [`b9a2add`](https://github.com/floccusaddon/floccus/commit/b9a2addb6bdd2f1b3f077b8da77206ef3f7d027f) Fix indentation - [`d81610c`](https://github.com/floccusaddon/floccus/commit/d81610c3992693bb30f96d014595600f80f9d70b) Fix trailing spaces - [`b64822a`](https://github.com/floccusaddon/floccus/commit/b64822a17e6efd2aa7c3046c3232b825e5effa11) Fix link issues in files unrelated to overall change ### 📊 Changes **8 files changed** (+188 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+5 -0) 📝 `_locales/zh_CN/messages.json` (+2 -2) ➕ `manifest-firefox-override.sh` (+30 -0) 📝 `package.json` (+3 -0) 📝 `src/lib/browser/BrowserTree.ts` (+20 -9) 📝 `src/test/test.js` (+122 -22) 📝 `src/ui/components/AccountCard.vue` (+4 -4) 📝 `src/ui/components/OptionsGoogleDrive.vue` (+2 -2) </details> ### 📄 Description This PR addresses https://github.com/floccusaddon/floccus/issues/1841: Firefox supports bookmark separator lines as a first-class concept, but other supported browsers do not. Fluccus mitigates that by creating dummy bookmarks looking like horizontal lines. This change ensures that when such dummy bookmarks are created in the Bookmark Toolbar, _vertical_ rather than _horizontal_ lines are used. #### Validation: * Added a unit test that exercises the new logic (`should convert vertical and horizontal separators`). * Manual validation by creating bookmarks and separators in different folders in Firefox, observing them being correctly synced to Edge, then being modified in Edge, and the changed being correctly synched back to Firefox. #### Other changes: * Add `npm` scripts to build under Windows. * Improve view of horizontal dummy separators by making them consecutive, slightly longer lines. * Fix a couple lint failures in random/unrelated files. #### Note: There appears to be a sync/diff issues with `_locales/zh_CN/messages.json` and `manifest-firefox-override.sh`. The files are identical to the `develop` branch, but a modification is being picked up. I think this was caused during cross-repo merges by multiple people somehow. A merge has not resolved that. To work around, let's merge this PR and subsequently manually validate that those files have the expected contents. If there are any issue, we will fix those contents in a separate PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-25 23:31:18 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/floccus#1943

No description provided.

Rows
Columns