starred/floccus

Fork 0

mirror of https://github.com/floccusaddon/floccus.git synced 2026-04-25 14:16:12 +03:00

[PR #1848] [MERGED] script to override manifest.json for Firefox and prevent accidental GIT commits #1942

New issue

Closed

opened 2026-02-25 23:31:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:31:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/floccusaddon/floccus/pull/1848
Author: @peter-lyons-kehl
Created: 1/27/2025
Status: ✅ Merged
Merged: 1/27/2025
Merged by: @marcelklehr

Base: develop ← Head: manifest-firefox-override

📝 Commits (1)

1341d31 For local development for Firefox.

📊 Changes

1 file changed (+30 additions, -0 deletions)

View changed files

➕ manifest-firefox-override.sh (+30 -0)

📄 Description

Thank you for Floccus. Hoping to contribute more.

You as an author of Floccus may have some more advanced setup that avoids the below problem, but for most developers (even ones with experience of developing Firefox extensions), the problem described below is a big time waster/accident maker. Hoping the workaround script is clear.

If you know of any more mistake/me-the-local-idiot-proof setup with less work or more reproducible/automated, I'm open to alternatives.

(Also in manifest-firefox-override.sh:)

Local development workaround for Firefox.

Once you build this extension (with npm install and npm run build, as per <README.md>), to load it, visit Firefox special URL about:debugging#/runtime/this-firefox. Click button "Load Temporary Add-on..." That button shows a file/folder picker.

Problem: The file picker does allow you to select manifest.firefox.json, BUT it will not load it. It loads manifest.json (from the directory where you selected manifest.firefox.json) instead. (Indeed, a Firefox defect - but life is too short for us to waste it on Mozilla's bugzilla....)

Firefox doesn't allow to use symlinks to workaround the above problem (see https://bugzilla.mozilla.org/show_bug.cgi?id=803999 - symlinks are a security problem).

Workaround: This script

copies manifest.firefox.json over manifest.json
prevents that change from being accidentally committed to GIT.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/floccusaddon/floccus/pull/1848 **Author:** [@peter-lyons-kehl](https://github.com/peter-lyons-kehl) **Created:** 1/27/2025 **Status:** ✅ Merged **Merged:** 1/27/2025 **Merged by:** [@marcelklehr](https://github.com/marcelklehr) **Base:** `develop` ← **Head:** `manifest-firefox-override` --- ### 📝 Commits (1) - [`1341d31`](https://github.com/floccusaddon/floccus/commit/1341d31f7bc5a60842fed6e4d7c8cbecfda724e9) For local development for Firefox. ### 📊 Changes **1 file changed** (+30 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `manifest-firefox-override.sh` (+30 -0) </details> ### 📄 Description Thank you for Floccus. Hoping to contribute more. You as an author of Floccus may have some more advanced setup that avoids the below problem, but for most developers (even ones with experience of developing Firefox extensions), the problem described below is a big time waster/accident maker. Hoping the workaround script is clear. If you know of any more mistake/me-the-local-idiot-proof setup with less work or more reproducible/automated, I'm open to alternatives. (Also in `manifest-firefox-override.sh`:) Local development workaround for Firefox. Once you build this extension (with `npm install` and `npm run build`, as per <README.md>), to load it, visit Firefox special URL about:debugging#/runtime/this-firefox. Click button "Load Temporary Add-on..." That button shows a file/folder picker. Problem: The file picker does allow you to select `manifest.firefox.json`, BUT it will not load it. It loads `manifest.json` (from the directory where you selected `manifest.firefox.json`) instead. (Indeed, a Firefox defect - but life is too short for us to waste it on Mozilla's bugzilla....) Firefox doesn't allow to use symlinks to workaround the above problem (see https://bugzilla.mozilla.org/show_bug.cgi?id=803999 - symlinks are a security problem). Workaround: This script 1. copies manifest.firefox.json over manifest.json 2. prevents that change from being accidentally committed to GIT. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-25 23:31:18 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-25 23:31:22 +03:00

[PR #1942] [CLOSED] Add Linkding support #1963

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/floccus#1942

No description provided.

Rows
Columns