[GH-ISSUE #119] Error Trying to create a URL that is already bookmarked #113

Closed
opened 2026-02-25 22:36:10 +03:00 by kerem · 12 comments
Owner

Originally created by @skewty on GitHub (Jun 5, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/119

Software versions

  • Browser: Firefox Developer Edition 61.0b10 64-bit
  • Nextcloud: 13.0.2
  • Nextcloud Bookmarks app: 0.11.0
  • Floccus: 2.2.7

Steps to reproduce

  1. Click [Sync now] on account that would always error before completing in previous version

Expected outcome

Sync completion without error.

Actual outcome

Error!

Trying to create a URL that is already bookmarked.  This shouldn't happen!  Please tell the developer about this!
url=http://1006beachavenue.com/
Originally created by @skewty on GitHub (Jun 5, 2018). Original GitHub issue: https://github.com/floccusaddon/floccus/issues/119 ### Software versions * Browser: Firefox Developer Edition 61.0b10 64-bit * Nextcloud: 13.0.2 * Nextcloud Bookmarks app: 0.11.0 * Floccus: 2.2.7 ### Steps to reproduce 1. Click [Sync now] on account that would always error before completing in previous version ### Expected outcome Sync completion without error. ### Actual outcome Error! ``` Trying to create a URL that is already bookmarked. This shouldn't happen! Please tell the developer about this! url=http://1006beachavenue.com/ ```
kerem 2026-02-25 22:36:10 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@marcelklehr commented on GitHub (Jun 5, 2018):

This error should be fixed, but it can still be the result of an earlier version of floccus as it usually only shows after upgrading or resetting the account. You have a duplicate bookmark on the server. Removing it should fix the error.

<!-- gh-comment-id:394779516 --> @marcelklehr commented on GitHub (Jun 5, 2018): This error should be fixed, but it can still be the result of an earlier version of floccus as it usually only shows after upgrading or resetting the account. You have a duplicate bookmark on the server. Removing it should fix the error.
Author
Owner

@marcelklehr commented on GitHub (Jun 21, 2018):

Did that help?

<!-- gh-comment-id:399226847 --> @marcelklehr commented on GitHub (Jun 21, 2018): Did that help?
Author
Owner

@skewty commented on GitHub (Jun 25, 2018):

Trying to create a URL that is already bookmarked. This shouldn't happen! Please tell the developer about this! url=https://gitlab.sec/

Browser: Chromium Version 65.0.3325.162 (Official Build) (64-bit)
Nextcloud Bookmarks: 0.12.0-rc1
Floccus: 2.2.8

I don't think it is fixed.

<!-- gh-comment-id:400004738 --> @skewty commented on GitHub (Jun 25, 2018): ``` Trying to create a URL that is already bookmarked. This shouldn't happen! Please tell the developer about this! url=https://gitlab.sec/ ``` Browser: Chromium Version 65.0.3325.162 (Official Build) (64-bit) Nextcloud Bookmarks: 0.12.0-rc1 Floccus: 2.2.8 I don't think it is fixed.
Author
Owner

@marcelklehr commented on GitHub (Jun 25, 2018):

Mh. Can you confirm by using search on the server, that there's two bookmarks for that url?

<!-- gh-comment-id:400006227 --> @marcelklehr commented on GitHub (Jun 25, 2018): Mh. Can you confirm by using search on the server, that there's two bookmarks for that url?
Author
Owner

@skewty commented on GitHub (Jun 25, 2018):

I believe it has to do with having a local bookmark that also / already exists on the server.

IMHO since duplicate bookmarks seem to be permitted on the server, they shouldn't crash floccus.

I got that error when trying to sync my "Toolbar" bookmarks. When I removed all the entries in my local copy of the toolbar and tried sync again, it worked.

I did run into an odd issue where floccus was left in some unrecoverable state though. When I clicked the icon all I got was an empty white surface with no widgets/controls/text. Restarting my browser didn't fix it (and yes I checked for background copies running). I quickly got around the issue by uninstalling and reinstalling floccus.

<!-- gh-comment-id:400015778 --> @skewty commented on GitHub (Jun 25, 2018): I believe it has to do with having a local bookmark that also / already exists on the server. IMHO since duplicate bookmarks seem to be permitted on the server, they shouldn't crash floccus. I got that error when trying to sync my "Toolbar" bookmarks. When I removed all the entries in my local copy of the toolbar and tried sync again, it worked. I did run into an odd issue where floccus was left in some unrecoverable state though. When I clicked the icon all I got was an empty white surface with no widgets/controls/text. Restarting my browser didn't fix it (and yes I checked for background copies running). I quickly got around the issue by uninstalling and reinstalling floccus.
Author
Owner

@marcelklehr commented on GitHub (Jun 25, 2018):

IMHO since duplicate bookmarks seem to be permitted on the server, they shouldn't crash floccus.

That's kind of a though spot, since the bookmarks app has certain constraints to ensure every URL is only stored once, but apparently those fail in some situations. In general I agree with you though.

The upcoming version of floccus will no longer depend on the server for merging local with remote bookmarks and will thus hopefully turn out to be more stable.

<!-- gh-comment-id:400029392 --> @marcelklehr commented on GitHub (Jun 25, 2018): > IMHO since duplicate bookmarks seem to be permitted on the server, they shouldn't crash floccus. That's kind of a though spot, since the bookmarks app has certain constraints to ensure every URL is only stored once, but apparently those fail in some situations. In general I agree with you though. The upcoming version of floccus will no longer depend on the server for merging local with remote bookmarks and will thus hopefully turn out to be more stable.
Author
Owner

@marcelklehr commented on GitHub (Jul 9, 2018):

You can now test the beta version over here #131 ;)

<!-- gh-comment-id:403551657 --> @marcelklehr commented on GitHub (Jul 9, 2018): You can now test the beta version over here #131 ;)
Author
Owner

@skewty commented on GitHub (Jul 12, 2018):

Getting this error using the v3 beta builds in #131:

bookmark is not defined bookmark is not defined
bookmark is not defined bookmark is not defined

In the debug console there is a failure at: Account.js:187:10
ReferenceError: "bookmark is not defined"

And then at: Account.js:170:6
Syncing failed with bookmark is not defined

Browser = Firefox

<!-- gh-comment-id:404601108 --> @skewty commented on GitHub (Jul 12, 2018): Getting this error using the v3 beta builds in #131: ``` bookmark is not defined bookmark is not defined bookmark is not defined bookmark is not defined ``` In the debug console there is a failure at: Account.js:187:10 ReferenceError: "bookmark is not defined" And then at: Account.js:170:6 Syncing failed with bookmark is not defined Browser = Firefox
Author
Owner

@marcelklehr commented on GitHub (Jul 16, 2018):

Ah, darn. What does the log say before the error appears?

<!-- gh-comment-id:405376172 --> @marcelklehr commented on GitHub (Jul 16, 2018): Ah, darn. What does the log say before the error appears?
Author
Owner

@marcelklehr commented on GitHub (Jul 18, 2018):

@skewty This should be fixed in the latest beta. Give it a go and preferably report any issues over here #131 ;)

<!-- gh-comment-id:405900957 --> @marcelklehr commented on GitHub (Jul 18, 2018): @skewty This should be fixed in the latest beta. Give it a go and preferably report any issues over here #131 ;)
Author
Owner

@marcelklehr commented on GitHub (Aug 22, 2018):

v3 is out 🎉 If you experience problems, feel free to open a new issue :)

<!-- gh-comment-id:415191320 --> @marcelklehr commented on GitHub (Aug 22, 2018): v3 is out :tada: If you experience problems, feel free to open a new issue :)
Author
Owner

@github-actions[bot] commented on GitHub (Mar 21, 2023):

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

<!-- gh-comment-id:1477739622 --> @github-actions[bot] commented on GitHub (Mar 21, 2023): This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/floccus#113
No description provided.