mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 22:26:06 +03:00
[GH-ISSUE #147] v3: Multi-tags bookmarks in odd way #138
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#138
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bernd-wechner on GitHub (Aug 23, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/147
I just tried the new v3. Nice.
My setup is:
local folder: root folder
server folder: empty
And to illustrate I will offer one example. I have this link:
http://ask.metafilter.com/mefi/45181
bookmarked under:
And it gets two tags in the NexCloud bookmarks after syncing once (which took well over a half hour) and then again (which finished very quickly) and these two tags are:
floccus:>Bookmarks Menu>Windows>Programming>C#
floccus:>Bookmarks Menu>BookmarksMenu>Windows>Programming>C#
See the problem. As far as I can tell all my bookmarks are double tagged like this.
My initial condition was:
Empty bookmarks app on nextcloud. I Truncated the two relevant tables in the database and tested the UI and it was nice and empty.
Synced my Firefox which has about 700 bookmarks.
@bernd-wechner commented on GitHub (Aug 23, 2018):
FYI I just synced a third time and still only two tags per bookmark as above. Not sure if they got two on the first sync or after the second. If I find time will empty table and repeat. Must run now.
@marcelklehr commented on GitHub (Aug 23, 2018):
mmh. Can you confirm there is no bookmarks folder in your browser in your Bookmarks Menu called "BookmarksMenu"?
@bernd-wechner commented on GitHub (Aug 23, 2018):
Good thought. Here's what I see in the Firefox BookMark editor:
That aside, it's odd giving one bookmark two tags, or is that expected somehow if the same bookmark is found in two browser folders?
@marcelklehr commented on GitHub (Aug 23, 2018):
@bernd-wechner
Mh. The screenshot doesn't show the contents of the bookmarks menu, though :)
That's exactly the point :) it didn't used to be allowed to have the same URL in different browser folders, but it works now in v3 via multiple path tags.
@bernd-wechner commented on GitHub (Aug 24, 2018):
You are good and patient Marcus, thank you so much! You are spot on!
I certainly never created that subfolder double up for everything! I suspect strongly it is an artifact of an earlier experience with floccus betas! Either way I will remove it and clean up NexCloud and start again! Yay! Looking a LOT like floccus is cool and stable slowly and working. Will report back if I find anything else of course.
@bernd-wechner commented on GitHub (Aug 24, 2018):
OK quick update:
I have now tested this by putting 3.01 on FF at home and work and did some back and forth. It was a tad messy with lots of dupes at first, but I tidied it up and it seems to have stabilised. As an FYI this query on the NextCloud database:
really helped me, and methinks a nice feature in floccus might be to add a "list duplicates" feature to the toolbar drop down, which reports such a thing.
Also of note is that order in menus is not preserved. There may be no easy way to dot hat with the BookMarks NextCloud app given it would need a column in oc_bookmarks to store a sort key or ordering key in. Just a side note as Xmarks did preserve order. That is the menus on one browser look the same as on the other, ordering preserved. The browsers themselves typically (in my experience) do this by storing bookmarks in an ordered file (like json file) rather than an orderless database table and so they win ordering as bonus. I left a note here about that:
https://github.com/nextcloud/bookmarks/issues/514
@marcelklehr commented on GitHub (Aug 24, 2018):
Ah, great it works now 🎉
The order is indeed an issue. It is only destroyed when you sync a browser for the first time. If you then rearrange the bookmarks and sync again, it should stay in your custom order. Still, order preservation is a good feature: see #113 ;)
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.