mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 22:26:06 +03:00
[GH-ISSUE #128] Sync not showing up on Nextcloud #119
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#119
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bernd-wechner on GitHub (Jun 18, 2018).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/128
Should it? I'm curious. I sort of expected it to. Config is:
Nextcloud: 13 (latest NextCloudPi image updated and up to date)
NextCloudPi: v0.56.22
Bookmark App: 0.11.0
Browser: Firefox 60.0.2 (64bit)
Floccus: 2.2.8
Floccus passes all tests:
Sync Now works without complaint:
And yet Nextcloud shows no bookmarks:
I suspect this is normal and my expectation is wrong, but wonder if that's true and if so why? Should I not see my bookmarks in Nextcloud? I've only tried with the one browser for not to get a feel for it. And admit I'm perplexed.
@marcelklehr commented on GitHub (Jun 18, 2018):
Mh. This is definitely not the expected behaviour. I couldn't replicate this with Firefox 60.0.1, Bookmarks 0.11 and floccus 2.2.8, though :/
Are you logged in with the correct account in the UI? :D
In any case, a glance at the logs might help:
In order to aid in debugging, please provide client-side logs.
Firefox
about:debuggingdebugbutton next to floccus entrysync nowfor the account of your choice.Chrome
chrome://extensionsDeveloper modedist/html/background.htmlbutton in floccus' entry next to "Inspect views: "sync nowfor the account of your choice@bernd-wechner commented on GitHub (Jun 18, 2018):
From Firefox:
I have a load of tabs open mind you so and there's a little baground activity, which on the console is only this message ever few seconds:
No matching message handler for the given recipient. MessageChannel.jsm:912so not sure that relates to floccus. Of course I can't read this diagnostic with experienced eyes, but the Array [ ] is not surprising as there are no bookmarks to receive from nextcloud, but the next line indicating Success is suspicious as I would like before then to see it send an array to Nextcloud. And of course the untrustworthy site connection is odd and suspiscious as the certs are fine. Here is the server I'm using:
https://tinyurl.com/ya4fextb
Regards,
I haven't tried with Chrome. Will do that next.
@bernd-wechner commented on GitHub (Jun 18, 2018):
Just tried Chrome. Same problem, but slightly more informative debug log I think:
But same issue as above, seemingly received nothing from NextCloud (fine as expected) then reports success but no apparent effort to push bookmarks to NextCloud.
@marcelklehr commented on GitHub (Jun 18, 2018):
Which folder did you select in the account options? It's probably a newly created one, as floccus by default tries not to destroy your bookmarks ;)
@bernd-wechner commented on GitHub (Jun 18, 2018):
I didn't select one in either case. I presume you're asking about the Sync Folder exposed when I click the Options button? I've never entered anything there.
When I look at it now in Firefox though it read something:
Though I never entered anything.
If I click Choose Folder there I get a popup with no way to close it:
If I click Reset then the box contains newly created. If I then click Sync now, the web page jumps to the Get Addons tab on the extensions page for some odd reason but if I navigate back to floccus page, I see it reports a successful sync and the Sync Folder again reads some value as in the image above.
@marcelklehr commented on GitHub (Jun 18, 2018):
The popup with no way to close it can be closed by clicking on the grey area (a close button is probably in order), or by selecting one of the folders that are listed there (if you hover over them you will see a tickbox appear). This allows you to select the folder to sync. By default, floccus will create an empty folder for you, thus nothing is happening, as you don't have anything in the newly created folder, nor on the server.
@bernd-wechner commented on GitHub (Jun 19, 2018):
Alas no change :-(.
Yes, a button or some UI clarity around that popup would be useful ;-).
Here is my config now:
And here is the FF debug trace of a sync:
And still on Nextcloud I see no bookmarks.
@bernd-wechner commented on GitHub (Jun 20, 2018):
I have since added Adminer to my NextCloud server to look at the database directly. And can confirm there is no data in the bookmarks tables there ;-). No surprise. For some reason floccus is simply not sending bookmarks to the server yet reports success on all its tests. Odd.
@marcelklehr commented on GitHub (Jun 20, 2018):
Could you try it without the server path, too. Just to be sure?
@bernd-wechner commented on GitHub (Jun 20, 2018):
No problem. Just tried again removing the server path. No change alas. I click Sync now and it reports success but nothing appears in NextCloud. Wondering if perhaps I should clone the repo and try and get my head around how it works. I could use some upskilling, alas a bit low on time. Looks like a little more instrumentation (debug output on the console) might help. Something is failing but failing silently and in a place not tested (as the tests all pass as per images above in the original post).
@marcelklehr commented on GitHub (Jun 21, 2018):
It's a strange one. Especially because your environment is totally normal. Does re-installing the extension help? Also, could you the same thing try with a new browser profile? I've had issues with older profiles before. The weird thing is that nothing is failing noisily.
Your report is similar to #123, though. Can you replicate the observation that the floccus-created folder does work for syncing?
@bernd-wechner commented on GitHub (Jun 22, 2018):
OK, tried that and it works. I now see bookmarks on nextcloud with the floccus: prefix.
Alas that is both encouraging and concerning. Because it poses two possible paths forward and I suspect and suggest perhaps we consider both at the same time:
I build this new profile up step by step to the same as the old (I mean I have a load of plugins to add basically and ideally a tab session). testing at each step a sync with a new bookmark to see if it appears. If at any point it stops working We have some info. Problem with this approach is I may get all the way back to a useable profile and we have learned nothing - that is, there is something in the old profile that is interfering that we can't identify easily. And that bugs me with regards to flocuss stability into the future as this is a costly process for us both already so I'd be happy to help out producing from it not just a workaround but learning ... and a possible lasting fix so it happens to no-one else.
You add some more debugging code, perhaps with an extra flag (advanced debugging) in which you dump to the console more info. I can imagine for example dumping the exact messages sent to the nextcloud server, the decision points on the way and the messages received back from it). A deep drill down in a sense. That will help us find the actual problem and improve lasting quality and stability of floccus. Do you agree?
@marcelklehr commented on GitHub (Jun 22, 2018):
Interesting. both #\1 and #\2 sound good to me. I'll send you an alpha version of floccus v3, though, as we've been rewriting some parts, so you can test the latest code.
Can you confirm this, too? In that case we can merge the two issues.
@marcelklehr commented on GitHub (Jun 22, 2018):
@bernd-wechner you can try this alpha version by going to
about:debugging, enabling debugging and loading the xpi file as a temporary addon. Make sure to uninstall the official floccus version first or at least to delete the account, to make sure they don't interfere. ;)@bernd-wechner commented on GitHub (Jun 24, 2018):
Mracel, been busy this weekend with a big event,. but just got around to trying this. Uninstalled Floccus from Firefox, ensured add-on debugging was enabled then tried to install the xpi you pointed to, but alas Firefox won't install it, complaining as follows:
I certainly have debugging on:
So I saw that Load Temporary Add-on button, downloaded the xpi file and clicked that button to load it and that worked. Cool. Entered by Nextcloud details and it failed to sync
But it fails to sync:
Yet still, passes all tests when they are run:
So I opened the debugging consoled and tried a sync and voila, we have more clues:
I'm sure you can read that better than I but I see:
Unhandled promise rejection TypeError: can't access dead object
and a stack trace that might help! I call that progress.
Oh and of course busy weekend it's been I've not progressed on my stepwise enhancement of the test profile (adding add-ons one by one). In case it helps BTW I do have a few extensions to try installing in that process and in case it helps they are:
@bernd-wechner commented on GitHub (Jun 25, 2018):
Hold our horses. I was tired last night and stopped at the reported error message in the UI and console. But this morning I checked my NextCloud instance and see that the bookmarks are there. I haven't checked them exhaustively but there are a load, and they look ;like mine ;-).
No thrill by the NextCloud Bookmarks UI and the need to use tags to mimic the hierarchy, but in the end it's not a huge issue clearly as that's just the store and the goal is to get them replicated on browsers. Still, nice to image on day the NextCloud Bookmarks app implements a tree-based organisation system ...
In the mean time it looks like the alpha does upload the bookmarks but dies on an error nonetheless, that needs diagnosing.
@marcelklehr commented on GitHub (Jun 25, 2018):
Mh. It's highly unlikely, that floccus created bookmarks without logging something about it in the console. I suspect the bookmarks on the server were still there from syncing with your new profile? I need to debug those dead object errors myself, but
Successfully ended sync processmeans the sync process was successful and flawless without errors. I suspect the dead object errors are from trying to update the options UI, the handle to which seems to die mid-way through.The UI will get better soon-ish, btw (heh, I've been saying that for a few months now 🙈)
@bernd-wechner commented on GitHub (Jun 26, 2018):
The new profile has none of those bookmarks so they can only have come from the old profile alas. It's quite a hassle to change profiles and use FF a lot so I've not got around to trying it again, but the new profile has only the default bookmarks and my old profile (which was managed by Xmarks) has hundreds of bookmarks well sorted into a hierarchy of interests that I'm used to seeing on all my instances of Firefox and Chrome (thanks to Xmarks which is no more). They are all froze now at the state they were when Xmarks was killed off. But it's easy for me to see the difference between the new test profiles handful of bookmarks and my customary huge list of them. What I can't easily see is if it's complete in Nextcloud, and I haven't tries synching Chrome to to yet either alas as I've been busy as, and ill. But that's a next step too.
Alas the UI is showing this error which pout me on hold and this diagnostic path. Still if ever I find/make time I will look at cloning and examining code myself too, but alas I am busy and the interest lies in the very fact that I have zero experience with Mozilla add-ons so far and am happy to upskill a bit plus of course help out on a cool project like this.
First things first though the Alpha needs to be free of that error report I guess, if it is working.
@bernd-wechner commented on GitHub (Jun 29, 2018):
Looking forward to version 3 ;-). Seems it'll fix the issue when stable.
@marcelklehr commented on GitHub (Jul 16, 2018):
The new beta version should work more stable. I'm closing this for now, since it appears to be fixed in the upcoming version.
@github-actions[bot] commented on GitHub (Mar 21, 2023):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.