[PR #1533] [MERGED] fix: secure passkey cookies #1696

Closed
opened 2026-02-26 20:30:41 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1533
Author: @dguyen
Created: 12/11/2024
Status: Merged
Merged: 12/11/2024
Merged by: @dguyen

Base: mainHead: fix/secure-passkey-cookies


📝 Commits (1)

  • 75f5928 fix: secure passkey cookies

📊 Changes

3 files changed (+16 additions, -10 deletions)

View changed files

📝 packages/lib/constants/auth.ts (+7 -0)
📝 packages/lib/next-auth/auth-options.ts (+6 -9)
📝 packages/trpc/server/auth-router/router.ts (+3 -1)

📄 Description

Description

Currently passkeys are failing due to missing secure cookies prefix.

Changes Made

  • Extract and reuse secure cookies logic

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1533 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 12/11/2024 **Status:** ✅ Merged **Merged:** 12/11/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/secure-passkey-cookies` --- ### 📝 Commits (1) - [`75f5928`](https://github.com/documenso/documenso/commit/75f5928696d6b5c515dbc5c87cbf3d2aa1206d6e) fix: secure passkey cookies ### 📊 Changes **3 files changed** (+16 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/constants/auth.ts` (+7 -0) 📝 `packages/lib/next-auth/auth-options.ts` (+6 -9) 📝 `packages/trpc/server/auth-router/router.ts` (+3 -1) </details> ### 📄 Description ## Description Currently passkeys are failing due to missing secure cookies prefix. ## Changes Made - Extract and reuse secure cookies logic --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 20:30:41 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1696
No description provided.