starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[PR #1281] [CLOSED] feat: auto-sign fields #1533

New issue

Closed

opened 2026-02-26 19:33:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1281
Author: @catalinpit
Created: 8/13/2024
Status: ❌ Closed

Base: main ← Head: feat/automated-fields-signature

📝 Commits (10+)

b15d901 feat: auto-sign fields
d6e51ce feat: disable remove button for date field
6505a40 feat: rework the name field
f74a239 feat: rework the initials field
a078865 Merge branch 'main' into feat/automated-fields-signature
75c05bf feat: some refactoring
29bc770 fix: auto-sign after value change
3783452 fix: variable name
4a7bab9 chore: merge main
0c8df9a Merge branch 'main' into feat/automated-fields-signature

📊 Changes

13 files changed (+98 additions, -104 deletions)

View changed files

📝 apps/marketing/process-env.d.ts (+2 -2)
📝 apps/web/process-env.d.ts (+1 -1)
📝 apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-data-table.tsx (+3 -1)
📝 apps/web/src/app/(recipient)/d/[token]/sign-direct-template.tsx (+0 -4)
📝 apps/web/src/app/(signing)/sign/[token]/date-field.tsx (+12 -31)
📝 apps/web/src/app/(signing)/sign/[token]/email-field.tsx (+15 -35)
📝 apps/web/src/app/(signing)/sign/[token]/initials-field.tsx (+17 -2)
📝 apps/web/src/app/(signing)/sign/[token]/name-field.tsx (+13 -1)
📝 apps/web/src/app/(signing)/sign/[token]/signing-field-container.tsx (+15 -9)
📝 packages/lib/server-only/feature-flags/all.ts (+5 -1)
📝 packages/lib/server-only/feature-flags/get.ts (+6 -2)
📝 packages/lib/translations/de/web.po (+5 -8)
📝 packages/lib/translations/en/web.po (+4 -7)

📄 Description

Description

Auto-sign the following fields:

Email
Date
Name
Initials

When the user visits the signing page, Documenso automatically signs those fields. If the name is not provided, the Name and Initials fields don't automatically sign.

https://github.com/user-attachments/assets/9287bd57-93fd-4247-9782-ca19d92b4093

Additional Information

The Date and Email fields are not removable/changeable.

However, the Name and Initials fields are changeable because documents can be sent without the name being provided. Or the document recipient might want to change the name.

https://github.com/user-attachments/assets/ebebf28e-f04b-4d97-bc66-159327d699d9

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Summary by CodeRabbit

New Features
- Enhanced authentication handling in the signing process across various fields (Email, Date, Initials, Name).
- Introduction of debounced input handling to improve user experience and performance during field interactions.
Bug Fixes
- Streamlined component interaction by removing the onUnsignField prop, simplifying functionality.
Refactor
- Improved code readability and maintainability by consolidating rendering logic for automated fields ('Email' and 'Date').
- Adjusted control flow in multiple fields to utilize debounced values for better user interaction management.
- Updated formatting for environment variable declarations to ensure consistency.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1281 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 8/13/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/automated-fields-signature` --- ### 📝 Commits (10+) - [`b15d901`](https://github.com/documenso/documenso/commit/b15d9019e3a151501266542eb8ea378e994959aa) feat: auto-sign fields - [`d6e51ce`](https://github.com/documenso/documenso/commit/d6e51ce5e641721b19a3aa0a88b81358205c16f0) feat: disable remove button for date field - [`6505a40`](https://github.com/documenso/documenso/commit/6505a400675304148f3e3053e1bd9a98e9d1c656) feat: rework the name field - [`f74a239`](https://github.com/documenso/documenso/commit/f74a2394741195eb3e114449e3ccd3d883546eff) feat: rework the initials field - [`a078865`](https://github.com/documenso/documenso/commit/a0788656f56a7c267d408409c79f8db65bd2474a) Merge branch 'main' into feat/automated-fields-signature - [`75c05bf`](https://github.com/documenso/documenso/commit/75c05bf82bd988514d7c84c9ee9c76da8aa2c52d) feat: some refactoring - [`29bc770`](https://github.com/documenso/documenso/commit/29bc7703328217bdb3418bf13b2927af7700428b) fix: auto-sign after value change - [`3783452`](https://github.com/documenso/documenso/commit/3783452031e4640651e220afe4aee431f534afe5) fix: variable name - [`4a7bab9`](https://github.com/documenso/documenso/commit/4a7bab912fbb6b3c651fbff95a9b3dbcd354b30e) chore: merge main - [`0c8df9a`](https://github.com/documenso/documenso/commit/0c8df9a94803aa5720f85b8ac3387063d30adac8) Merge branch 'main' into feat/automated-fields-signature ### 📊 Changes **13 files changed** (+98 additions, -104 deletions) <details> <summary>View changed files</summary> 📝 `apps/marketing/process-env.d.ts` (+2 -2) 📝 `apps/web/process-env.d.ts` (+1 -1) 📝 `apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-data-table.tsx` (+3 -1) 📝 `apps/web/src/app/(recipient)/d/[token]/sign-direct-template.tsx` (+0 -4) 📝 `apps/web/src/app/(signing)/sign/[token]/date-field.tsx` (+12 -31) 📝 `apps/web/src/app/(signing)/sign/[token]/email-field.tsx` (+15 -35) 📝 `apps/web/src/app/(signing)/sign/[token]/initials-field.tsx` (+17 -2) 📝 `apps/web/src/app/(signing)/sign/[token]/name-field.tsx` (+13 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/signing-field-container.tsx` (+15 -9) 📝 `packages/lib/server-only/feature-flags/all.ts` (+5 -1) 📝 `packages/lib/server-only/feature-flags/get.ts` (+6 -2) 📝 `packages/lib/translations/de/web.po` (+5 -8) 📝 `packages/lib/translations/en/web.po` (+4 -7) </details> ### 📄 Description ## Description Auto-sign the following fields: * Email * Date * Name * Initials When the user visits the signing page, Documenso automatically signs those fields. If the name is not provided, the Name and Initials fields don't automatically sign. https://github.com/user-attachments/assets/9287bd57-93fd-4247-9782-ca19d92b4093 ## Additional Information The Date and Email fields are not removable/changeable. However, the Name and Initials fields are changeable because documents can be sent without the name being provided. Or the document recipient might want to change the name. https://github.com/user-attachments/assets/ebebf28e-f04b-4d97-bc66-159327d699d9 ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable.  ## Summary by CodeRabbit - **New Features** - Enhanced authentication handling in the signing process across various fields (Email, Date, Initials, Name). - Introduction of debounced input handling to improve user experience and performance during field interactions. - **Bug Fixes** - Streamlined component interaction by removing the `onUnsignField` prop, simplifying functionality. - **Refactor** - Improved code readability and maintainability by consolidating rendering logic for automated fields ('Email' and 'Date'). - Adjusted control flow in multiple fields to utilize debounced values for better user interaction management. - Updated formatting for environment variable declarations to ensure consistency.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:39 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:30:41 +03:00

[PR #1533] [MERGED] fix: secure passkey cookies #1696

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1533

No description provided.

Rows
Columns