[PR #1696] [MERGED] fix: autosigning fields with direct links #1798

New issue

Closed

opened 2026-02-26 20:31:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1696
Author: @catalinpit
Created: 3/11/2025
Status: ✅ Merged
Merged: 3/13/2025
Merged by: @catalinpit

Base: feat/rr7 ← Head: fix/autosign-fields-direct-links

📝 Commits (5)

80d5047 fix: autosigning fields with direct links
f39645e fix: improve checkbox handling and value assignment in signing process
76b5077 fix: improve logic for autosigning
59c87ee fix: remove uneeded checkbox code
6bebf9c fix: fix checkboxes

📊 Changes

2 files changed (+71 additions, -6 deletions)

View changed files

📝 apps/remix/app/components/general/direct-template/direct-template-signing-form.tsx (+50 -1)
📝 apps/remix/app/components/general/document-signing/document-signing-checkbox-field.tsx (+21 -5)

📄 Description

Description

The changes in sign-direct-template.tsx automatically fill in field values for text, number, and dropdown fields when default values are present or if the fields are read-only. In checkbox-field.tsx, the changes fix the checkbox signing by checking if the validation is met and improving how it saves or removes checkbox choices.

Testing Performed

I tested the code locally with a variety of documents/fields.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1696 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 3/11/2025 **Status:** ✅ Merged **Merged:** 3/13/2025 **Merged by:** [@catalinpit](https://github.com/catalinpit) **Base:** `feat/rr7` ← **Head:** `fix/autosign-fields-direct-links` --- ### 📝 Commits (5) - [`80d5047`](https://github.com/documenso/documenso/commit/80d5047a1bef96c25ecad8ead196e2ce3751187a) fix: autosigning fields with direct links - [`f39645e`](https://github.com/documenso/documenso/commit/f39645ea81dad4a167d113224f6253601b326111) fix: improve checkbox handling and value assignment in signing process - [`76b5077`](https://github.com/documenso/documenso/commit/76b5077b2dc829c2f98484ae432a406647697902) fix: improve logic for autosigning - [`59c87ee`](https://github.com/documenso/documenso/commit/59c87ee86c226b1ed4926fdd012e18dcab2c39db) fix: remove uneeded checkbox code - [`6bebf9c`](https://github.com/documenso/documenso/commit/6bebf9c88570c89b26849cc6de003169b678699c) fix: fix checkboxes ### 📊 Changes **2 files changed** (+71 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/general/direct-template/direct-template-signing-form.tsx` (+50 -1) 📝 `apps/remix/app/components/general/document-signing/document-signing-checkbox-field.tsx` (+21 -5) </details> ### 📄 Description ## Description The changes in `sign-direct-template.tsx` automatically fill in field values for text, number, and dropdown fields when default values are present or if the fields are read-only. In `checkbox-field.tsx`, the changes fix the checkbox signing by checking if the validation is met and improving how it saves or removes checkbox choices. ## Testing Performed I tested the code locally with a variety of documents/fields. ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:07 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:22 +03:00

[PR #1798] [MERGED] fix: remove preconnect font links #1855

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1798

No description provided.

Rows
Columns