starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[PR #1149] [MERGED] fix: downloaded files should have _signed #1427

New issue

Closed

opened 2026-02-26 19:33:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1149
Author: @ephraimduncan
Created: 5/7/2024
Status: ✅ Merged
Merged: 6/5/2024
Merged by: @Mythie

Base: main ← Head: fix/download-filenames

📝 Commits (1)

f363dee fix: downloaded files should have _signed

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/lib/client-only/download-pdf.ts (+1 -1)

📄 Description

Description

Modifies the generated filename for the downloaded PDF by appending "_signed" to the base title.

N/A

Changes Made

Update the filename in the downloadFile function call to append "_signed" to the baseTitle variable.

Testing Performed

Tested the downloadPDF function locally to ensure that the downloaded PDF file has the correct filename with "_signed" appended.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1149 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 5/7/2024 **Status:** ✅ Merged **Merged:** 6/5/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/download-filenames` --- ### 📝 Commits (1) - [`f363dee`](https://github.com/documenso/documenso/commit/f363dee761087de4b80775daed70ec224b88c29f) fix: downloaded files should have _signed ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/client-only/download-pdf.ts` (+1 -1) </details> ### 📄 Description ## Description Modifies the generated filename for the downloaded PDF by appending "_signed" to the base title. ## Related Issue N/A ## Changes Made - Update the filename in the downloadFile function call to append "_signed" to the baseTitle variable. ## Testing Performed Tested the `downloadPDF` function locally to ensure that the downloaded PDF file has the correct filename with "_signed" appended. ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [x] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:12 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:34:03 +03:00

[PR #1427] [MERGED] feat: improve translation coverage #1623

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1427

No description provided.

Rows
Columns