[PR #1427] [MERGED] feat: improve translation coverage #1623

New issue

Closed

opened 2026-02-26 19:34:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:34:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1427
Author: @dguyen
Created: 10/30/2024
Status: ✅ Merged
Merged: 10/31/2024
Merged by: @Mythie

Base: main ← Head: feat/improve-translation-coverage

📝 Commits (3)

4aa861f feat: improve translation coverage
2f13189 fix: delete confirmation translations
34827b1 fix: refactor

📊 Changes

41 files changed (+1746 additions, -439 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx (+1 -1)
📝 apps/web/src/app/(dashboard)/documents/move-document-dialog.tsx (+2 -2)
📝 apps/web/src/app/(recipient)/d/[token]/configure-direct-template.tsx (+2 -2)
📝 apps/web/src/app/(signing)/sign/[token]/complete/page.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/form.tsx (+11 -7)
📝 apps/web/src/app/(signing)/sign/[token]/initials-field.tsx (+8 -5)
📝 apps/web/src/app/(unauthenticated)/articles/signature-disclosure/page.tsx (+112 -57)
📝 apps/web/src/components/(dashboard)/document-search/document-search.tsx (+7 -1)
📝 apps/web/src/components/(dashboard)/settings/token/contants.ts (+7 -5)
📝 apps/web/src/components/(dashboard)/settings/token/delete-token-dialog.tsx (+1 -1)
📝 apps/web/src/components/(dashboard)/settings/webhooks/delete-webhook-dialog.tsx (+1 -1)
📝 apps/web/src/components/(teams)/dialogs/delete-team-dialog.tsx (+1 -1)
📝 apps/web/src/components/(teams)/dialogs/transfer-team-dialog.tsx (+1 -1)
📝 apps/web/src/components/(teams)/tables/current-user-teams-data-table.tsx (+1 -1)
📝 apps/web/src/components/(teams)/tables/team-members-data-table.tsx (+1 -1)
📝 apps/web/src/components/document/document-read-only-fields.tsx (+6 -2)
📝 apps/web/src/components/forms/token.tsx (+1 -1)
📝 apps/web/src/components/general/signing-disclosure.tsx (+19 -13)
📝 packages/lib/client-only/providers/i18n.server.tsx (+11 -1)
📝 packages/lib/constants/recipient-roles.ts (+4 -0)

...and 21 more files

📄 Description

Description

These changes will improve translation coverage across the app.

Resolves #1426

Changes Made

Load common.po for development
Improve translation coverage
Add some handling for showing translated error messages with Zod and Form
Fix issue where typing delete in a confirmation box would not work
Remove invalid translations where the result is English

Summary by CodeRabbit

Release Notes

New Features
- Enhanced internationalization support across various components, allowing for localized messages and labels.
- Added localization for confirmation messages in delete dialogs and error messages in forms.
- Introduced a "Never expire" toggle option for API tokens in the token creation form.
- Updated placeholder texts and error messages to support multiple languages in forms and dialogs.
Bug Fixes
- Improved error handling and user feedback for email validation and document loading errors.
Style
- Adjusted styling for improved layout and spacing in various components.
Documentation
- Updated localization files to include new and modified translation entries for multiple languages.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1427 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 10/30/2024 **Status:** ✅ Merged **Merged:** 10/31/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/improve-translation-coverage` --- ### 📝 Commits (3) - [`4aa861f`](https://github.com/documenso/documenso/commit/4aa861fc8aa41c5c2d3458354ab706f0267be1db) feat: improve translation coverage - [`2f13189`](https://github.com/documenso/documenso/commit/2f13189d564abe558b1ad3aa603c9f78ba80393b) fix: delete confirmation translations - [`34827b1`](https://github.com/documenso/documenso/commit/34827b1f0a3666f302490fadfdf78ccd6330d71e) fix: refactor ### 📊 Changes **41 files changed** (+1746 additions, -439 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx` (+1 -1) 📝 `apps/web/src/app/(dashboard)/documents/move-document-dialog.tsx` (+2 -2) 📝 `apps/web/src/app/(recipient)/d/[token]/configure-direct-template.tsx` (+2 -2) 📝 `apps/web/src/app/(signing)/sign/[token]/complete/page.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/form.tsx` (+11 -7) 📝 `apps/web/src/app/(signing)/sign/[token]/initials-field.tsx` (+8 -5) 📝 `apps/web/src/app/(unauthenticated)/articles/signature-disclosure/page.tsx` (+112 -57) 📝 `apps/web/src/components/(dashboard)/document-search/document-search.tsx` (+7 -1) 📝 `apps/web/src/components/(dashboard)/settings/token/contants.ts` (+7 -5) 📝 `apps/web/src/components/(dashboard)/settings/token/delete-token-dialog.tsx` (+1 -1) 📝 `apps/web/src/components/(dashboard)/settings/webhooks/delete-webhook-dialog.tsx` (+1 -1) 📝 `apps/web/src/components/(teams)/dialogs/delete-team-dialog.tsx` (+1 -1) 📝 `apps/web/src/components/(teams)/dialogs/transfer-team-dialog.tsx` (+1 -1) 📝 `apps/web/src/components/(teams)/tables/current-user-teams-data-table.tsx` (+1 -1) 📝 `apps/web/src/components/(teams)/tables/team-members-data-table.tsx` (+1 -1) 📝 `apps/web/src/components/document/document-read-only-fields.tsx` (+6 -2) 📝 `apps/web/src/components/forms/token.tsx` (+1 -1) 📝 `apps/web/src/components/general/signing-disclosure.tsx` (+19 -13) 📝 `packages/lib/client-only/providers/i18n.server.tsx` (+11 -1) 📝 `packages/lib/constants/recipient-roles.ts` (+4 -0) _...and 21 more files_ </details> ### 📄 Description ## Description These changes will improve translation coverage across the app. ## Related Issue Resolves #1426 ## Changes Made - Load common.po for development - Improve translation coverage - Add some handling for showing translated error messages with `Zod` and `Form` - Fix issue where typing `delete` in a confirmation box would not work - Remove invalid translations where the result is English  ## Summary by CodeRabbit ## Release Notes - **New Features** - Enhanced internationalization support across various components, allowing for localized messages and labels. - Added localization for confirmation messages in delete dialogs and error messages in forms. - Introduced a "Never expire" toggle option for API tokens in the token creation form. - Updated placeholder texts and error messages to support multiple languages in forms and dialogs. - **Bug Fixes** - Improved error handling and user feedback for email validation and document loading errors. - **Style** - Adjusted styling for improved layout and spacing in various components. - **Documentation** - Updated localization files to include new and modified translation entries for multiple languages.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:34:03 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1623

No description provided.

Rows
Columns