[PR #736] [MERGED] fix: add conditional rendering of OAuth providers #1149

New issue

Closed

opened 2026-02-26 19:32:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:32:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/736
Author: @anuragts
Created: 12/6/2023
Status: ✅ Merged
Merged: 1/23/2024
Merged by: @dguyen

Base: main ← Head: googleauth

📝 Commits (5)

262141f fix: add conditional rendering of OAuth providers
b87dd69 fix: rename variable to more descriptive one
f9dd987 Merge branch 'main' into googleauth
9507378 Merge branch 'main' into googleauth
befbf2c Merge branch 'main' into googleauth

📊 Changes

3 files changed (+30 additions, -18 deletions)

View changed files

📝 apps/web/src/app/(unauthenticated)/signin/page.tsx (+3 -1)
📝 apps/web/src/components/forms/signin.tsx (+23 -17)
📝 packages/lib/constants/auth.ts (+4 -0)

📄 Description

Now google OAuth provider is not rendered if client id is not provided

fixes - #735

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/736 **Author:** [@anuragts](https://github.com/anuragts) **Created:** 12/6/2023 **Status:** ✅ Merged **Merged:** 1/23/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `googleauth` --- ### 📝 Commits (5) - [`262141f`](https://github.com/documenso/documenso/commit/262141f3840c775ca8fe2ebc6a00148a2e0ff25b) fix: add conditional rendering of OAuth providers - [`b87dd69`](https://github.com/documenso/documenso/commit/b87dd69d047135932b87d2e04f79d8d961a4bf5e) fix: rename variable to more descriptive one - [`f9dd987`](https://github.com/documenso/documenso/commit/f9dd98720f3935358bc9c4c0c5c73b64eb7f5bdd) Merge branch 'main' into googleauth - [`9507378`](https://github.com/documenso/documenso/commit/950737862c9504160cd401102eb977a2de21946b) Merge branch 'main' into googleauth - [`befbf2c`](https://github.com/documenso/documenso/commit/befbf2ca9f1b36d9e0d5a37258e622ec7b60b7ec) Merge branch 'main' into googleauth ### 📊 Changes **3 files changed** (+30 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(unauthenticated)/signin/page.tsx` (+3 -1) 📝 `apps/web/src/components/forms/signin.tsx` (+23 -17) 📝 `packages/lib/constants/auth.ts` (+4 -0) </details> ### 📄 Description Now google OAuth provider is not rendered if client id is not provided ![Screenshot from 2023-12-06 17-39-09](https://github.com/documenso/documenso/assets/79055093/4c427141-0bd0-43c2-a875-121c58f00ed7) fixes - #735 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:32:02 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:12 +03:00

[PR #1149] [MERGED] fix: downloaded files should have _signed #1427

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1149

No description provided.

Rows
Columns