[PR #600] [MERGED] feat: improving incorrect default signature behaviour #594 #1071

Closed
opened 2026-02-26 19:31:43 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/600
Author: @TameemAsim
Created: 10/27/2023
Status: Merged
Merged: 11/1/2023
Merged by: @Mythie

Base: feat/refreshHead: feat-improvement-incorrect-default-signature-#594


📝 Commits (9)

  • d2268b1 feat: solving incorrect default signature #594
  • bc9d2ec feat: improved default signature behaviour-update package-lock.json
  • abe2cbb corrected my own mistake
  • e4b60a4 Merge branch 'documenso:feat/refresh' into feat-improvement-incorrect-default-signature-#594
  • b139165 fix: changed incorrect default behaviour of name
  • 849826f Merge branch 'documenso:feat/refresh' into feat-improvement-incorrect-default-signature-#594
  • bf521c7 fix: made changes in page containing provider instead of form
  • 980fcd5 Merge branch 'documenso:feat/refresh' into feat-improvement-incorrect-default-signature-#594
  • 07074a0 feat: added recipient name speacified by author

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 apps/web/src/app/(signing)/sign/[token]/page.tsx (+5 -1)

📄 Description

This PR fixes #594 .

This PR improves default signature behaviour so that when a user is signed in, if signer's email is not same as logged in user's email, then signature pad will be empty.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/600 **Author:** [@TameemAsim](https://github.com/TameemAsim) **Created:** 10/27/2023 **Status:** ✅ Merged **Merged:** 11/1/2023 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `feat/refresh` ← **Head:** `feat-improvement-incorrect-default-signature-#594` --- ### 📝 Commits (9) - [`d2268b1`](https://github.com/documenso/documenso/commit/d2268b17307e5f29af8f59cfb1d8b9407ed87444) feat: solving incorrect default signature #594 - [`bc9d2ec`](https://github.com/documenso/documenso/commit/bc9d2ec57faf111cfa6581c8a336f8c44eed4800) feat: improved default signature behaviour-update package-lock.json - [`abe2cbb`](https://github.com/documenso/documenso/commit/abe2cbb87686f9704d1a85e22e6c364af8a791ed) corrected my own mistake - [`e4b60a4`](https://github.com/documenso/documenso/commit/e4b60a47d08bdf2b8ab5cab69b0dc3a3dcf38f36) Merge branch 'documenso:feat/refresh' into feat-improvement-incorrect-default-signature-#594 - [`b139165`](https://github.com/documenso/documenso/commit/b1391652c5ea43086eeaecd62eccf65064995326) fix: changed incorrect default behaviour of name - [`849826f`](https://github.com/documenso/documenso/commit/849826fb183fa23c3cfd89ed473a8469324bb955) Merge branch 'documenso:feat/refresh' into feat-improvement-incorrect-default-signature-#594 - [`bf521c7`](https://github.com/documenso/documenso/commit/bf521c72f173fe2f04a5f20d60da195f3b515515) fix: made changes in page containing provider instead of form - [`980fcd5`](https://github.com/documenso/documenso/commit/980fcd59651bd7d5425dc47636701557ecd86453) Merge branch 'documenso:feat/refresh' into feat-improvement-incorrect-default-signature-#594 - [`07074a0`](https://github.com/documenso/documenso/commit/07074a0ab1e18d809747105bc502d66f840d593e) feat: added recipient name speacified by author ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(signing)/sign/[token]/page.tsx` (+5 -1) </details> ### 📄 Description This PR fixes #594 . This PR improves default signature behaviour so that when a user is signed in, if signer's email is not same as logged in user's email, then signature pad will be empty. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:31:43 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1071
No description provided.