[PR #37] [MERGED] Add responseHeaders field to Result class #38

New issue

Closed

opened 2026-02-26 17:32:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 17:32:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Corsinvest/cv4pve-api-php/pull/37
Author: @sydive
Created: 7/29/2024
Status: ✅ Merged
Merged: 7/29/2024
Merged by: @franklupo

Base: master ← Head: response-headers

📝 Commits (1)

efe59d9 Add responseHeaders field to Result class

📊 Changes

3 files changed (+21 additions, -2 deletions)

View changed files

📝 README.md (+1 -0)
📝 src/PveClientBase.php (+3 -1)
📝 src/Result.php (+17 -1)

📄 Description

This change adds a responseHeaders field to the Result class, which contains the raw HTTP headers for a response. The main motivation here is that PVE API can sometimes put error messages in the headers, instead of in the JSON response body.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Corsinvest/cv4pve-api-php/pull/37 **Author:** [@sydive](https://github.com/sydive) **Created:** 7/29/2024 **Status:** ✅ Merged **Merged:** 7/29/2024 **Merged by:** [@franklupo](https://github.com/franklupo) **Base:** `master` ← **Head:** `response-headers` --- ### 📝 Commits (1) - [`efe59d9`](https://github.com/Corsinvest/cv4pve-api-php/commit/efe59d9f63744d58545ebd7b0103c686d7f5eb37) Add responseHeaders field to Result class ### 📊 Changes **3 files changed** (+21 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -0) 📝 `src/PveClientBase.php` (+3 -1) 📝 `src/Result.php` (+17 -1) </details> ### 📄 Description This change adds a `responseHeaders` field to the `Result` class, which contains the raw HTTP headers for a response. The main motivation here is that PVE API can sometimes put error messages in the headers, instead of in the JSON response body. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>