[PR #31] [MERGED] Add Timeout for cURL #37

New issue

Closed

opened 2026-02-26 17:32:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 17:32:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Corsinvest/cv4pve-api-php/pull/31
Author: @noxomix
Created: 2/27/2024
Status: ✅ Merged
Merged: 2/28/2024
Merged by: @franklupo

Base: master ← Head: master

📝 Commits (2)

48adbc6 Add Timeout for curl into the PveClientBase | using CURLOPT_TIMEOUT_MS-parameter
b890fc8 Added test | Changed from MS to S for compatibility | Add doc

📊 Changes

3 files changed (+39 additions, -0 deletions)

View changed files

📝 README.md (+4 -0)
📝 src/PveClientBase.php (+32 -0)
📝 tests/test.php (+3 -0)

📄 Description

Added documentation.
Added test.
setTimeout() returns now $this for support of method-chaining.
Instead of CURLOPT_TIMEOUT_MS now using CURLOPT_TIMEOUT for compatibility.
No Timeout by default.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Corsinvest/cv4pve-api-php/pull/31 **Author:** [@noxomix](https://github.com/noxomix) **Created:** 2/27/2024 **Status:** ✅ Merged **Merged:** 2/28/2024 **Merged by:** [@franklupo](https://github.com/franklupo) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`48adbc6`](https://github.com/Corsinvest/cv4pve-api-php/commit/48adbc6da9b8e534fafef325e30269b59c42cd40) Add Timeout for curl into the PveClientBase | using CURLOPT_TIMEOUT_MS-parameter - [`b890fc8`](https://github.com/Corsinvest/cv4pve-api-php/commit/b890fc83271c4d0b137b04fc8b55919a03f42eb0) Added test | Changed from MS to S for compatibility | Add doc ### 📊 Changes **3 files changed** (+39 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+4 -0) 📝 `src/PveClientBase.php` (+32 -0) 📝 `tests/test.php` (+3 -0) </details> ### 📄 Description - Added documentation. - Added test. - `setTimeout()` returns now $this for support of method-chaining. - Instead of `CURLOPT_TIMEOUT_MS` now using `CURLOPT_TIMEOUT` for compatibility. - No Timeout by default. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>