[PR #38] [MERGED] added missing query (parameters) to URL in DELETE method #39

New issue

Closed

opened 2026-02-26 17:32:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 17:32:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Corsinvest/cv4pve-api-php/pull/38
Author: @lukasbruha
Created: 7/13/2025
Status: ✅ Merged
Merged: 7/14/2025
Merged by: @franklupo

Base: master ← Head: missing-delete-query-fix

📝 Commits (1)

9555292 added missing query (parameters) to URL in DELETE method (eg. getPrunebackups()->delete(...))

📊 Changes

1 file changed (+8 additions, -0 deletions)

View changed files

📝 src/PveClientBase.php (+8 -0)

📄 Description

DELETE method in PveClientBase::executeAction() had missing query in URL which is optionally expected sometimes, eg. in PVEStorageStorageNodeNodesPrunebackups::delete($prune_backups = null, $type = null, $vmid = null). Without this update delete() behavior cannot be influenced anyhow.

I have copied the same lines from GET method handling its URL query.

Can you merge this update it to master, please?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Corsinvest/cv4pve-api-php/pull/38 **Author:** [@lukasbruha](https://github.com/lukasbruha) **Created:** 7/13/2025 **Status:** ✅ Merged **Merged:** 7/14/2025 **Merged by:** [@franklupo](https://github.com/franklupo) **Base:** `master` ← **Head:** `missing-delete-query-fix` --- ### 📝 Commits (1) - [`9555292`](https://github.com/Corsinvest/cv4pve-api-php/commit/95552926f9a061d71f67253ff3ca02c7756fe33a) added missing query (parameters) to URL in DELETE method (eg. getPrunebackups()->delete(...)) ### 📊 Changes **1 file changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/PveClientBase.php` (+8 -0) </details> ### 📄 Description DELETE method in PveClientBase::executeAction() had missing query in URL which is optionally expected sometimes, eg. in PVEStorageStorageNodeNodesPrunebackups::delete($prune_backups = null, $type = null, $vmid = null). Without this update delete() behavior cannot be influenced anyhow. I have copied the same lines from GET method handling its URL query. Can you merge this update it to master, please? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>