[PR #13] [MERGED] Fix waitForTaskToFinish1 & waitForTaskToFinish #31

New issue

Closed

opened 2026-02-26 17:32:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 17:32:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Corsinvest/cv4pve-api-php/pull/13
Author: @Nexus633
Created: 2/24/2021
Status: ✅ Merged
Merged: 2/25/2021
Merged by: @franklupo

Base: master ← Head: patch-2

📝 Commits (1)

4800a01 Fix waitForTaskToFinish1 & waitForTaskToFinish

📊 Changes

1 file changed (+6 additions, -3 deletions)

View changed files

📝 src/PveClientBase.php (+6 -3)

📄 Description

Fix while of waitForTaskToFinish -> while ($isRunning && (time() - $timeStart) < $timeOut) { -> while (($isRunning && (time() - $timeStart)) < $timeOut) {
Fix waitForTaskToFinish1 node string explode. my preg_split was wrong. Sorry for that

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Corsinvest/cv4pve-api-php/pull/13 **Author:** [@Nexus633](https://github.com/Nexus633) **Created:** 2/24/2021 **Status:** ✅ Merged **Merged:** 2/25/2021 **Merged by:** [@franklupo](https://github.com/franklupo) **Base:** `master` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`4800a01`](https://github.com/Corsinvest/cv4pve-api-php/commit/4800a0127275a60ffe17c3d0c9c26c3aa7550fe7) Fix waitForTaskToFinish1 & waitForTaskToFinish ### 📊 Changes **1 file changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/PveClientBase.php` (+6 -3) </details> ### 📄 Description Fix while of waitForTaskToFinish -> while ($isRunning && (time() - $timeStart) < $timeOut) { -> while (($isRunning && (time() - $timeStart)) < $timeOut) { Fix waitForTaskToFinish1 node string explode. my preg_split was wrong. Sorry for that --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>