[PR #1763] [MERGED] Revert breaking docker socket changes #2117

New issue

Closed

opened 2026-03-01 21:54:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:54:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1763
Author: @ChristopherHX
Created: 4/24/2023
Status: ✅ Merged
Merged: 4/25/2023
Merged by: @mergify[bot]

Base: master ← Head: wip-revert-breaking-changes

📝 Commits (10+)

56baa04 fix: rework docker socket changes
449fbd6 fixup
438273b fixup
6e9e9c6 fixes
0287ab8 patch
d79efdf ...
d87d884 lint
3376a3a Fix docker outputs windows
a18b6c2 fix type
f94832d Revert containerDaemonSocket breaking change

📊 Changes

2 files changed (+56 additions, -15 deletions)

View changed files

📝 cmd/root.go (+34 -13)
📝 pkg/runner/run_context.go (+22 -2)

📄 Description

Also allow disabling mounting the docker socket via -

Closes #1756
Closes #1757, more handling

Changes

Prefer DOCKER_HOST, don't override it. (BREAKING change of a previous change)
update input.containerDaemonSocket to the found socket and pass it to the config instead of socketPath
bind mount /var/run/docker.sock on windows and ssh or other protocols, strip protocol of unix socketPath

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1763 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 4/24/2023 **Status:** ✅ Merged **Merged:** 4/25/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `wip-revert-breaking-changes` --- ### 📝 Commits (10+) - [`56baa04`](https://github.com/nektos/act/commit/56baa04cb9761a0968f682e3c19317dd9fae4f4a) fix: rework docker socket changes - [`449fbd6`](https://github.com/nektos/act/commit/449fbd60abf954083c20573768765e1ae17e1516) fixup - [`438273b`](https://github.com/nektos/act/commit/438273bd17309f3b6f97ef4174aeea606729666e) fixup - [`6e9e9c6`](https://github.com/nektos/act/commit/6e9e9c6d69b03fa1123a2540073b9ba7d1f2995e) fixes - [`0287ab8`](https://github.com/nektos/act/commit/0287ab818af6f83c36d01750b466292bc78468c8) patch - [`d79efdf`](https://github.com/nektos/act/commit/d79efdfd2e58354b05ccd81e8ba504d1f96f6904) ... - [`d87d884`](https://github.com/nektos/act/commit/d87d884d38e94d6b59942710a384205d14e0614f) lint - [`3376a3a`](https://github.com/nektos/act/commit/3376a3a81cd9b1cfb6e96b00a8c595a2e59031f9) Fix docker outputs windows - [`a18b6c2`](https://github.com/nektos/act/commit/a18b6c232510fd3083b25999becc1fe0a7d98c7e) fix type - [`f94832d`](https://github.com/nektos/act/commit/f94832d3ed79b1f191d8d3dfc4385b269b1664ff) Revert containerDaemonSocket breaking change ### 📊 Changes **2 files changed** (+56 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `cmd/root.go` (+34 -13) 📝 `pkg/runner/run_context.go` (+22 -2) </details> ### 📄 Description Also allow disabling mounting the docker socket via `-` Closes #1756 Closes #1757, more handling Changes - Prefer DOCKER_HOST, don't override it. (BREAKING change of a previous change) - update input.containerDaemonSocket to the found socket and pass it to the config instead of socketPath - bind mount `/var/run/docker.sock` on windows and ssh or other protocols, strip protocol of unix socketPath --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:54:05 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:44 +03:00

[PR #2117] [MERGED] build(deps): bump github.com/go-git/go-git/v5 from 5.10.1 to 5.11.0 #2274

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2117

No description provided.

Rows
Columns