[PR #1074] [MERGED] fix: copy ignored tracked files #1756

New issue

Closed

opened 2026-03-01 21:52:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1074
Author: @ChristopherHX
Created: 3/24/2022
Status: ✅ Merged
Merged: 4/4/2022
Merged by: @mergify[bot]

Base: master ← Head: fix/copyignoredtrackedfiles

📝 Commits (10+)

abcfaa5 fix: copy ignored tracked files
ec5e2ca fix
6241229 refactor: Extract callback to fileCollector
9c41a58 Move nolint: gocyclo
10d1a2d pass context as parameter
967d2d8 goimport
2e7cfed Add fs interface + one test
85be076 fix lint, also test for ignored non tracked file
a41aa20 fix filename
8020f24 Apply suggestions from code review

📊 Changes

3 files changed (+321 additions, -65 deletions)

View changed files

📝 pkg/container/docker_run.go (+21 -65)
➕ pkg/container/file_collector.go (+183 -0)
➕ pkg/container/file_collector_test.go (+117 -0)

📄 Description

Resolves #912
Resolves #1002
Closes #949

What I have tested:

copy without git directory in current folder => old behavior
copy with git directory, now includes all tracked files even those which are ignored
first level of submodules
you can now cancel the copydir by pressing ctrl+c

~~I'm not shure how to write tests for this change.~~

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1074 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 3/24/2022 **Status:** ✅ Merged **Merged:** 4/4/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix/copyignoredtrackedfiles` --- ### 📝 Commits (10+) - [`abcfaa5`](https://github.com/nektos/act/commit/abcfaa57dceb2c52d4946f666770c30124c0470d) fix: copy ignored tracked files - [`ec5e2ca`](https://github.com/nektos/act/commit/ec5e2cad27489757a3d48fb9dce6f734c2bdeeba) fix - [`6241229`](https://github.com/nektos/act/commit/6241229f89aaa195c0f4786457333f156f025997) refactor: Extract callback to fileCollector - [`9c41a58`](https://github.com/nektos/act/commit/9c41a582460237a2c77b440a1f175edc976d262d) Move nolint: gocyclo - [`10d1a2d`](https://github.com/nektos/act/commit/10d1a2dda25f09d80fbccd999e5586ef7139a7ea) pass context as parameter - [`967d2d8`](https://github.com/nektos/act/commit/967d2d8e5fe1b71fadf5b6d9d55db0212589168b) goimport - [`2e7cfed`](https://github.com/nektos/act/commit/2e7cfed490236d8d6d7fa3bd9a9e22d9e3976939) Add fs interface + one test - [`85be076`](https://github.com/nektos/act/commit/85be07663062c2c12a703d5429c78a8e7b0c2a60) fix lint, also test for ignored non tracked file - [`a41aa20`](https://github.com/nektos/act/commit/a41aa209732f93d6f2b33b015323f6d728034ee1) fix filename - [`8020f24`](https://github.com/nektos/act/commit/8020f24596a179ed60123026d81919e6d7c4911f) Apply suggestions from code review ### 📊 Changes **3 files changed** (+321 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/docker_run.go` (+21 -65) ➕ `pkg/container/file_collector.go` (+183 -0) ➕ `pkg/container/file_collector_test.go` (+117 -0) </details> ### 📄 Description Resolves #912 Resolves #1002 Closes #949 What I have tested: - copy without git directory in current folder => old behavior - copy with git directory, now includes all tracked files even those which are ignored - first level of submodules - you can now cancel the copydir by pressing ctrl+c ~~I'm not shure how to write tests for this change.~~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>