[PR #1083] [MERGED] refactor: simplify action function signatures #1763

New issue

Closed

opened 2026-03-01 21:52:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:52:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1083
Author: @KnisterPeter
Created: 3/28/2022
Status: ✅ Merged
Merged: 3/29/2022
Merged by: @mergify[bot]

Base: master ← Head: simplify-action-interfaces

📝 Commits (2)

9e9555f refactor: simplify action function signatures
148b0f2 Merge branch 'master' into simplify-action-interfaces

📊 Changes

7 files changed (+106 additions, -96 deletions)

View changed files

📝 pkg/runner/action.go (+95 -83)
📝 pkg/runner/action_test.go (+1 -3)
📝 pkg/runner/run_context.go (+1 -1)
📝 pkg/runner/step_action_local.go (+1 -1)
📝 pkg/runner/step_action_local_test.go (+3 -3)
📝 pkg/runner/step_action_remote.go (+1 -1)
📝 pkg/runner/step_action_remote_test.go (+4 -4)

📄 Description

This change reduces the interfaces by removing
obsolete parameters from functions.
Obsolete parameters does not means unused ones, but
parameters which could be retrieved from other parameters
instead.

This should simplify logic and maintainability for these
functions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1083 **Author:** [@KnisterPeter](https://github.com/KnisterPeter) **Created:** 3/28/2022 **Status:** ✅ Merged **Merged:** 3/29/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `simplify-action-interfaces` --- ### 📝 Commits (2) - [`9e9555f`](https://github.com/nektos/act/commit/9e9555f9a787543c5437dcb6b718a8b8cd2f3973) refactor: simplify action function signatures - [`148b0f2`](https://github.com/nektos/act/commit/148b0f23820c9d2965f6c8f6da0dc0d198959857) Merge branch 'master' into simplify-action-interfaces ### 📊 Changes **7 files changed** (+106 additions, -96 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/action.go` (+95 -83) 📝 `pkg/runner/action_test.go` (+1 -3) 📝 `pkg/runner/run_context.go` (+1 -1) 📝 `pkg/runner/step_action_local.go` (+1 -1) 📝 `pkg/runner/step_action_local_test.go` (+3 -3) 📝 `pkg/runner/step_action_remote.go` (+1 -1) 📝 `pkg/runner/step_action_remote_test.go` (+4 -4) </details> ### 📄 Description This change reduces the interfaces by removing obsolete parameters from functions. Obsolete parameters does not means unused ones, but parameters which could be retrieved from other parameters instead. This should simplify logic and maintainability for these functions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:52:35 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:54:05 +03:00

[PR #1763] [MERGED] Revert breaking docker socket changes #2117

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1763

No description provided.

Rows
Columns