[PR #1532] [MERGED] fix: add-matcher fails github workflow #1990

Closed
opened 2026-03-01 21:53:33 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1532
Author: @ChristopherHX
Created: 12/20/2022
Status: Merged
Merged: 1/13/2023
Merged by: @mergify[bot]

Base: masterHead: fix-add-matcher-failure


📝 Commits (3)

  • 0690e10 fix: add-matcher fails github workflow
  • fa26001 make linter happy
  • 3e3a460 Merge branch 'master' into fix-add-matcher-failure

📊 Changes

2 files changed (+35 additions, -29 deletions)

View changed files

📝 pkg/runner/command.go (+19 -12)
📝 pkg/runner/testdata/uses-nested-composite/composite_action2/action.yml (+16 -17)

📄 Description

This finally avoids failing tests due to add-matcher commands of setup-node on github actions, these tests don't fail if they are not run by actions/runner


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1532 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 12/20/2022 **Status:** ✅ Merged **Merged:** 1/13/2023 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `fix-add-matcher-failure` --- ### 📝 Commits (3) - [`0690e10`](https://github.com/nektos/act/commit/0690e106a6bac86cbbd8649d63f6d19123321b6b) fix: add-matcher fails github workflow - [`fa26001`](https://github.com/nektos/act/commit/fa26001033a8839f645a11b57f8a5d4c6723e800) make linter happy - [`3e3a460`](https://github.com/nektos/act/commit/3e3a460047daf0a80264416ed3dc544b67b838cd) Merge branch 'master' into fix-add-matcher-failure ### 📊 Changes **2 files changed** (+35 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/command.go` (+19 -12) 📝 `pkg/runner/testdata/uses-nested-composite/composite_action2/action.yml` (+16 -17) </details> ### 📄 Description This finally avoids failing tests due to add-matcher commands of setup-node on github actions, these tests don't fail if they are not run by actions/runner --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:53:33 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1990
No description provided.