[PR #2422] [MERGED] fix GOOS parsing to match expected GHA RUNNER_OS values #2437

New issue

Closed

opened 2026-03-01 21:55:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:55:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/2422
Author: @benniekiss
Created: 8/12/2024
Status: ✅ Merged
Merged: 8/13/2024
Merged by: @mergify[bot]

Base: master ← Head: better_goos_parsing

📝 Commits (2)

df213e9 fix GOOS parsing to match expected GHA RUNNER_OS values
aec7373 Merge branch 'master' into better_goos_parsing

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 pkg/container/host_environment.go (+2 -0)

📄 Description

github actions reports RUNNER_OS for linux and windows with capital letters (Linux, Windows). This should increase compatibility when runner uses -self-hosted

Currently, when workflows are run within containers, RUNNER_OS is hardcoded to Linux correctly, so this will make RUNNER_OS more consistent.

Closes #1990

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/2422 **Author:** [@benniekiss](https://github.com/benniekiss) **Created:** 8/12/2024 **Status:** ✅ Merged **Merged:** 8/13/2024 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `better_goos_parsing` --- ### 📝 Commits (2) - [`df213e9`](https://github.com/nektos/act/commit/df213e928c2133c13c8d1cbd26c932a08cbec13c) fix GOOS parsing to match expected GHA RUNNER_OS values - [`aec7373`](https://github.com/nektos/act/commit/aec7373c96ef60eb6b6342745e5bf32c06cf4414) Merge branch 'master' into better_goos_parsing ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkg/container/host_environment.go` (+2 -0) </details> ### 📄 Description github actions reports RUNNER_OS for linux and windows with [capital letters](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/variables#default-environment-variables) (Linux, Windows). This should increase compatibility when runner uses `-self-hosted` Currently, when workflows are run within containers, RUNNER_OS is [hardcoded](https://github.com/search?q=repo%3Anektos%2Fact+RUNNER_OS&type=code) to `Linux` correctly, so this will make RUNNER_OS more consistent. Closes #1990 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:55:26 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#2437

No description provided.

Rows
Columns