[PR #637] [MERGED] Fixes Issue #597 #1532

New issue

Closed

opened 2026-03-01 21:51:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/637
Author: @Renstrom
Created: 4/25/2021
Status: ✅ Merged
Merged: 5/3/2021
Merged by: @cplee

Base: master ← Head: issueIfWith

📝 Commits (5)

805c8e5 feat:(Changed order of events, to prevent enviroment to run before if statement is run
466ee65 changed issue597 to issue-597
8c3855c Added test for linux/amd64
06d7aeb Merge branch 'master' into issueIfWith
b645f71 Merge branch 'master' into issueIfWith

📊 Changes

3 files changed (+47 additions, -7 deletions)

View changed files

📝 pkg/runner/run_context.go (+13 -7)
📝 pkg/runner/runner_test.go (+2 -0)
➕ pkg/runner/testdata/issue-597/spelling.yaml (+32 -0)

📄 Description

Fixes #597

Due to the order of events, the stepenv was evaluated before the if statement was checked. This fix changes the order of events aswell as tests to test this. Inspiration of the test was taken from #597.

As I understand the code, I think this solution fixes it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/637 **Author:** [@Renstrom](https://github.com/Renstrom) **Created:** 4/25/2021 **Status:** ✅ Merged **Merged:** 5/3/2021 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `issueIfWith` --- ### 📝 Commits (5) - [`805c8e5`](https://github.com/nektos/act/commit/805c8e53fcfdb9078980bfde1576065e2726f097) feat:(Changed order of events, to prevent enviroment to run before if statement is run - [`466ee65`](https://github.com/nektos/act/commit/466ee65f971d06773c7b256b4411cf4146697522) changed issue597 to issue-597 - [`8c3855c`](https://github.com/nektos/act/commit/8c3855c1c42c3cf925264fde8f99a2b4a3b2db28) Added test for linux/amd64 - [`06d7aeb`](https://github.com/nektos/act/commit/06d7aeb6b5c72e5c8e7f3bc42abbda0c667f9082) Merge branch 'master' into issueIfWith - [`b645f71`](https://github.com/nektos/act/commit/b645f71347eae15057d86e893a85ca43571ec2dc) Merge branch 'master' into issueIfWith ### 📊 Changes **3 files changed** (+47 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/run_context.go` (+13 -7) 📝 `pkg/runner/runner_test.go` (+2 -0) ➕ `pkg/runner/testdata/issue-597/spelling.yaml` (+32 -0) </details> ### 📄 Description Fixes #597 Due to the order of events, the stepenv was evaluated before the if statement was checked. This fix changes the order of events aswell as tests to test this. Inspiration of the test was taken from #597. As I understand the code, I think this solution fixes it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:34 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:33 +03:00

[PR #1532] [MERGED] fix: add-matcher fails github workflow #1990

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1532

No description provided.

Rows
Columns