[PR #1496] [MERGED] feat: JobLoggerFactory #1968

New issue

Closed

opened 2026-03-01 21:53:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:53:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/1496
Author: @ChristopherHX
Created: 12/8/2022
Status: ✅ Merged
Merged: 12/9/2022
Merged by: @mergify[bot]

Base: master ← Head: feat-jobloggerfactory

📝 Commits (1)

5a5c1a5 feat: JobLoggerFactory

📊 Changes

2 files changed (+62 additions, -35 deletions)

View changed files

📝 pkg/runner/logger.go (+46 -32)
📝 pkg/runner/runner_test.go (+16 -3)

📄 Description

Remove overriding io.Stdout in TestMaskValues to prevent deadlock in GitHub Actions
Print log of TestMaskValues in Test

captureOutput is unsafe and causes a deadlock in https://github.com/nektos/act/pull/1472

I tested merging this change into #1472 and it unblocks the failing test.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/1496 **Author:** [@ChristopherHX](https://github.com/ChristopherHX) **Created:** 12/8/2022 **Status:** ✅ Merged **Merged:** 12/9/2022 **Merged by:** [@mergify[bot]](https://github.com/apps/mergify) **Base:** `master` ← **Head:** `feat-jobloggerfactory` --- ### 📝 Commits (1) - [`5a5c1a5`](https://github.com/nektos/act/commit/5a5c1a529550860db14152cb557f855eb934388b) feat: JobLoggerFactory ### 📊 Changes **2 files changed** (+62 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/logger.go` (+46 -32) 📝 `pkg/runner/runner_test.go` (+16 -3) </details> ### 📄 Description - Remove overriding io.Stdout in TestMaskValues to prevent deadlock in GitHub Actions - Print log of TestMaskValues in Test _captureOutput is unsafe and causes a deadlock in https://github.com/nektos/act/pull/1472_ _I tested merging this change into #1472 and it unblocks the failing test._ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:53:28 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1968

No description provided.

Rows
Columns