starred/act

Fork 0

mirror of https://github.com/nektos/act.git synced 2026-04-26 01:15:51 +03:00

[PR #560] [MERGED] Update test workflows and improve `expression_test.go`/`run_context_test.go` #1496

New issue

Closed

opened 2026-03-01 21:51:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 21:51:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/560
Author: @catthehacker
Created: 3/11/2021
Status: ✅ Merged
Merged: 3/13/2021
Merged by: @cplee

Base: master ← Head: test-workflows

📝 Commits (4)

0e85d69 fix: give case insensitive secret more meanigful name
3759be3 refactor: use string in generating env: and steps: for workflows
21c41a7 feat: sort keys for env: so it's always in specific order
7fe3612 fix: update test workflows

📊 Changes

4 files changed (+472 additions, -466 deletions)

View changed files

📝 .github/workflows/test-expressions.yml (+53 -47)
📝 .github/workflows/test-if.yml (+392 -392)
📝 pkg/runner/expression_test.go (+16 -12)
📝 pkg/runner/run_context_test.go (+11 -15)

📄 Description

@cplee I've missed adding tests in workflows in #470 which this PR will fix, but it requires to add secret CASE_INSENSITIVE_SECRET in GitHub repo settings with value: value

additional note: diff between current master workflows and in this PR is enormous because I've added additional space (so it's exactly 2 spaces per each indentation level, instead of 2 everywhere and 1 space in steps)

added missing test in workflows for case insensitive secrets and change it's name
added sorting keys in env:, so it should stop showing up in every PR
replaced some raw string literals with normal strings (this is probably subjective opinion which is better to use so I'm fine with removing that commit)

and obviously forgot to push latest changes when creating pr 🤦‍♂️

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/560 **Author:** [@catthehacker](https://github.com/catthehacker) **Created:** 3/11/2021 **Status:** ✅ Merged **Merged:** 3/13/2021 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `test-workflows` --- ### 📝 Commits (4) - [`0e85d69`](https://github.com/nektos/act/commit/0e85d69b88d1ba4f58a1c6d7510a34c7c934e0e7) fix: give case insensitive secret more meanigful name - [`3759be3`](https://github.com/nektos/act/commit/3759be355f104639c876e6df8935b1ad2a9fee84) refactor: use `string` in generating `env:` and `steps:` for workflows - [`21c41a7`](https://github.com/nektos/act/commit/21c41a7c05d318f2012f8c2bceed1d918864652e) feat: sort keys for `env:` so it's always in specific order - [`7fe3612`](https://github.com/nektos/act/commit/7fe3612a78c6dbac89805c2489552772424ce77e) fix: update test workflows ### 📊 Changes **4 files changed** (+472 additions, -466 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test-expressions.yml` (+53 -47) 📝 `.github/workflows/test-if.yml` (+392 -392) 📝 `pkg/runner/expression_test.go` (+16 -12) 📝 `pkg/runner/run_context_test.go` (+11 -15) </details> ### 📄 Description @cplee I've missed adding tests in workflows in #470 which this PR will fix, but it requires to add secret `CASE_INSENSITIVE_SECRET` in GitHub repo settings with value: `value` additional note: diff between current `master` workflows and in this PR is enormous because I've added additional space (so it's exactly 2 spaces per each indentation level, instead of 2 everywhere and 1 space in steps) ![image](https://user-images.githubusercontent.com/31106839/110831704-cbc21200-829a-11eb-99a1-f5f65347c847.png) - added missing test in workflows for case insensitive secrets and change it's name - added sorting keys in `env:`, so it should stop showing up in every PR - replaced some raw string literals with normal strings (this is probably subjective opinion which is better to use so I'm fine with removing that commit) *and obviously forgot to push latest changes when creating pr* 🤦‍♂️ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 21:51:25 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-01 21:53:28 +03:00

[PR #1496] [MERGED] feat: JobLoggerFactory #1968

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/act#1496

No description provided.

Rows
Columns

[PR #560] [MERGED] Update test workflows and improve expression_test.go/run_context_test.go #1496

📋 Pull Request Information

📝 Commits (4)

📊 Changes

📄 Description

[PR #560] [MERGED] Update test workflows and improve `expression_test.go`/`run_context_test.go` #1496