[PR #495] [MERGED] Stop current execution if there is the invalid syntax in the workflow #1472

Closed
opened 2026-03-01 21:51:19 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/nektos/act/pull/495
Author: @lufia
Created: 1/21/2021
Status: Merged
Merged: 1/21/2021
Merged by: @cplee

Base: masterHead: warn-no-ref


📝 Commits (1)

  • bdb4cf7 Stop current execution if there is the invalid syntax in the workflow

📊 Changes

1 file changed (+9 additions, -2 deletions)

View changed files

📝 pkg/runner/step_context.go (+9 -2)

📄 Description

I changed uses: directive syntax to the same behavior to the current GitHub Actions.

Closes #438

After this changes was merged, act started with the workflow having invalid uses directive will stop with an invalid syntax error, like:

% new-act push
[Continuous integration/check] 🚀  Start image=catthehacker/ubuntu:act-latest
[Continuous integration/check]   🐳  docker run image=catthehacker/ubuntu:act-latest entrypoint=["/usr/bin/tail" "-f" "/dev/null"] cmd=[]
[Continuous integration/check]   🐳  docker cp src=(snip) dst=/github/workspace
[Continuous integration/check] ⭐  Run actions/checkout@v2
[Continuous integration/check]   ✅  Success - actions/checkout@v2
[Continuous integration/check] ⭐  Run OskarStark/php-cs-fixer-ga
[Continuous integration/check]   ❌  Failure - OskarStark/php-cs-fixer-ga
Error: Expected format {org}/{repo}[/path]@ref. Actual 'OskarStark/php-cs-fixer-ga' Input string was not in a correct format.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/nektos/act/pull/495 **Author:** [@lufia](https://github.com/lufia) **Created:** 1/21/2021 **Status:** ✅ Merged **Merged:** 1/21/2021 **Merged by:** [@cplee](https://github.com/cplee) **Base:** `master` ← **Head:** `warn-no-ref` --- ### 📝 Commits (1) - [`bdb4cf7`](https://github.com/nektos/act/commit/bdb4cf74e78044a7b8d0f957fdbcb5af46cc4f42) Stop current execution if there is the invalid syntax in the workflow ### 📊 Changes **1 file changed** (+9 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `pkg/runner/step_context.go` (+9 -2) </details> ### 📄 Description I changed `uses:` directive syntax to the same behavior to the current GitHub Actions. Closes #438 After this changes was merged, act started with the workflow having invalid uses directive will stop with an invalid syntax error, like: ```console % new-act push [Continuous integration/check] 🚀 Start image=catthehacker/ubuntu:act-latest [Continuous integration/check] 🐳 docker run image=catthehacker/ubuntu:act-latest entrypoint=["/usr/bin/tail" "-f" "/dev/null"] cmd=[] [Continuous integration/check] 🐳 docker cp src=(snip) dst=/github/workspace [Continuous integration/check] ⭐ Run actions/checkout@v2 [Continuous integration/check] ✅ Success - actions/checkout@v2 [Continuous integration/check] ⭐ Run OskarStark/php-cs-fixer-ga [Continuous integration/check] ❌ Failure - OskarStark/php-cs-fixer-ga Error: Expected format {org}/{repo}[/path]@ref. Actual 'OskarStark/php-cs-fixer-ga' Input string was not in a correct format. ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-01 21:51:19 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/act#1472
No description provided.